Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Issue 2533483002: [DevTools] Typed events and event listeners. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
index 3616263ac050f151e60f7213914d8f8037298465..5a5ff0010d1f9300303ec69cb909548eedc95392 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
@@ -531,16 +531,16 @@ UI.TabbedPane = class extends UI.VBox {
var dropDownContainer = createElementWithClass('div', 'tabbed-pane-header-tabs-drop-down-container');
dropDownContainer.createChild('div', 'glyph');
this._dropDownMenu = new UI.DropDownMenu(dropDownContainer);
- this._dropDownMenu.addEventListener(UI.DropDownMenu.Events.ItemSelected, this._dropDownMenuItemSelected, this);
+ this._dropDownMenu.addEventListener(UI.DropDownMenu.ItemSelectedEvent, this._dropDownMenuItemSelected, this);
return dropDownContainer;
}
/**
- * @param {!Common.Event} event
+ * @param {!UI.DropDownMenu.ItemSelectedEvent} event
*/
_dropDownMenuItemSelected(event) {
- var tabId = /** @type {string} */ (event.data);
+ var tabId = event.id;
this._lastSelectedOverflowTab = this._tabsById[tabId];
this.selectTab(tabId, true);
}

Powered by Google App Engine
This is Rietveld 408576698