Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Issue 2533483002: [DevTools] Typed events and event listeners. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
index 303f117d8a35bfd0a5dfb9f35422a3106c1cfae5..e9ab6d0d46f7cbefd16de142644a76d6c54d41e2 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
@@ -42,13 +42,10 @@ Resources.DOMStorageItemsView = class extends UI.SimpleView {
this.refreshButton = new UI.ToolbarButton(Common.UIString('Refresh'), 'largeicon-refresh');
this.refreshButton.addEventListener('click', this._refreshButtonClicked, this);
- this.domStorage.addEventListener(
- Resources.DOMStorage.Events.DOMStorageItemsCleared, this._domStorageItemsCleared, this);
- this.domStorage.addEventListener(
- Resources.DOMStorage.Events.DOMStorageItemRemoved, this._domStorageItemRemoved, this);
- this.domStorage.addEventListener(Resources.DOMStorage.Events.DOMStorageItemAdded, this._domStorageItemAdded, this);
- this.domStorage.addEventListener(
- Resources.DOMStorage.Events.DOMStorageItemUpdated, this._domStorageItemUpdated, this);
+ this.domStorage.addEventListener(Resources.DOMStorage.ItemsClearedEvent, this._domStorageItemsCleared, this);
+ this.domStorage.addEventListener(Resources.DOMStorage.ItemRemovedEvent, this._domStorageItemRemoved, this);
+ this.domStorage.addEventListener(Resources.DOMStorage.ItemAddedEvent, this._domStorageItemAdded, this);
+ this.domStorage.addEventListener(Resources.DOMStorage.ItemUpdatedEvent, this._domStorageItemUpdated, this);
}
/**
@@ -74,7 +71,7 @@ Resources.DOMStorageItemsView = class extends UI.SimpleView {
}
/**
- * @param {!Common.Event} event
+ * @param {!Resources.DOMStorage.ItemsClearedEvent} event
*/
_domStorageItemsCleared(event) {
if (!this.isShowing() || !this._dataGrid)
@@ -83,25 +80,21 @@ Resources.DOMStorageItemsView = class extends UI.SimpleView {
this._dataGrid.rootNode().removeChildren();
this._dataGrid.addCreationNode(false);
this.deleteButton.setVisible(false);
- event.consume(true);
}
/**
- * @param {!Common.Event} event
+ * @param {!Resources.DOMStorage.ItemRemovedEvent} event
*/
_domStorageItemRemoved(event) {
if (!this.isShowing() || !this._dataGrid)
return;
- var storageData = event.data;
var rootNode = this._dataGrid.rootNode();
var children = rootNode.children;
- event.consume(true);
-
for (var i = 0; i < children.length; ++i) {
var childNode = children[i];
- if (childNode.data.key === storageData.key) {
+ if (childNode.data.key === event.key) {
rootNode.removeChild(childNode);
this.deleteButton.setVisible(children.length > 1);
return;
@@ -110,52 +103,46 @@ Resources.DOMStorageItemsView = class extends UI.SimpleView {
}
/**
- * @param {!Common.Event} event
+ * @param {!Resources.DOMStorage.ItemAddedEvent} event
*/
_domStorageItemAdded(event) {
if (!this.isShowing() || !this._dataGrid)
return;
- var storageData = event.data;
var rootNode = this._dataGrid.rootNode();
var children = rootNode.children;
-
- event.consume(true);
this.deleteButton.setVisible(true);
for (var i = 0; i < children.length; ++i) {
- if (children[i].data.key === storageData.key)
+ if (children[i].data.key === event.key)
return;
}
- var childNode = new UI.DataGridNode({key: storageData.key, value: storageData.value}, false);
+ var childNode = new UI.DataGridNode({key: event.key, value: event.value}, false);
rootNode.insertChild(childNode, children.length - 1);
}
/**
- * @param {!Common.Event} event
+ * @param {!Resources.DOMStorage.ItemUpdatedEvent} event
*/
_domStorageItemUpdated(event) {
if (!this.isShowing() || !this._dataGrid)
return;
- var storageData = event.data;
var rootNode = this._dataGrid.rootNode();
var children = rootNode.children;
- event.consume(true);
-
var keyFound = false;
for (var i = 0; i < children.length; ++i) {
var childNode = children[i];
- if (childNode.data.key === storageData.key) {
+ if (childNode.data.key === event.key) {
if (keyFound) {
rootNode.removeChild(childNode);
return;
}
keyFound = true;
- if (childNode.data.value !== storageData.value) {
- childNode.data.value = storageData.value;
+ if (childNode.data.value !== event.newValue) {
+ childNode.data.value = event.newValue;
childNode.refresh();
childNode.select();
childNode.reveal();

Powered by Google App Engine
This is Rietveld 408576698