Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2531863002: Delete all the traces of federation providers in the account chooser. (Closed)

Created:
4 years ago by vasilii
Modified:
4 years ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete all the traces of federation providers in the account chooser. The list of the federation provider credentials has always been empty. It is to be dropped. BUG=400674 Committed: https://crrev.com/dea4e7fa1487cfae33f1c20a297002c3ad13518f Cr-Commit-Position: refs/heads/master@{#434527}

Patch Set 1 #

Patch Set 2 : android #

Patch Set 3 : android2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -235 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/password_manager/account_chooser_dialog_android.h View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/account_chooser_dialog_android.cc View 1 2 7 chunks +9 lines, -31 lines 0 comments Download
M chrome/browser/password_manager/account_chooser_dialog_android_unittest.cc View 1 2 4 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/credential_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/password_manager/credential_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_state.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_state.cc View 4 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_state_unittest.cc View 34 chunks +4 lines, -64 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 12 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc View 4 chunks +3 lines, -20 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/passwords_client_ui_delegate.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/passwords/passwords_model_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/passwords_model_delegate_mock.h View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (14 generated)
vasilii
Hi guys, please review bauerb: chrome/android vabr: everything else
4 years ago (2016-11-25 16:11:52 UTC) #9
vabr (Chromium)
LGTM. After speaking to Vasilii, I understand that this does not remove support for saved ...
4 years ago (2016-11-25 16:32:31 UTC) #12
Bernhard Bauer
lgtm
4 years ago (2016-11-25 16:38:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531863002/40001
4 years ago (2016-11-25 16:41:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-25 16:46:37 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-25 16:50:14 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dea4e7fa1487cfae33f1c20a297002c3ad13518f
Cr-Commit-Position: refs/heads/master@{#434527}

Powered by Google App Engine
This is Rietveld 408576698