Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 2531863002: Delete all the traces of federation providers in the account chooser. (Closed)
Patch Set: android2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc
index 54104859414e440634a7ae30f67443298289efdc..45f9f1fc3ab49b0aa6ed4ecc35384419c53b594e 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc
@@ -99,11 +99,9 @@ void ManagePasswordsState::OnUpdatePassword(
void ManagePasswordsState::OnRequestCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
- std::vector<std::unique_ptr<autofill::PasswordForm>> federation_providers,
const GURL& origin) {
ClearData();
local_credentials_forms_ = std::move(local_credentials);
- federation_providers_forms_ = std::move(federation_providers);
origin_ = origin;
SetState(password_manager::ui::CREDENTIAL_REQUEST_STATE);
}
@@ -187,7 +185,6 @@ void ManagePasswordsState::TransitionToState(
credentials_callback_.Run(nullptr);
credentials_callback_.Reset();
}
- federation_providers_forms_.clear();
}
SetState(state);
}
@@ -224,7 +221,6 @@ void ManagePasswordsState::ChooseCredential(
void ManagePasswordsState::ClearData() {
form_manager_.reset();
local_credentials_forms_.clear();
- federation_providers_forms_.clear();
credentials_callback_.Reset();
}
@@ -238,14 +234,11 @@ void ManagePasswordsState::AddForm(const autofill::PasswordForm& form) {
}
bool ManagePasswordsState::UpdateForm(const autofill::PasswordForm& form) {
- bool updated_locals = UpdateFormInVector(form, &local_credentials_forms_);
- return (UpdateFormInVector(form, &federation_providers_forms_) ||
- updated_locals);
+ return UpdateFormInVector(form, &local_credentials_forms_);
}
void ManagePasswordsState::DeleteForm(const autofill::PasswordForm& form) {
RemoveFormFromVector(form, &local_credentials_forms_);
- RemoveFormFromVector(form, &federation_providers_forms_);
}
void ManagePasswordsState::SetState(password_manager::ui::State state) {
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.h ('k') | chrome/browser/ui/passwords/manage_passwords_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698