Hide PSL matches in the password bubble after the account chooser.

Hide PSL matches in the password bubble after the account chooser.

The PSL matches can be shown in the account chooser. The "Manage passwords" bubble can appear after the dialog was dismissed. It should be empty because the PSL matches aren't saved for the current site.

BUG=666340
Committed: https://crrev.com/9fbb8593200ef0defadc83add39b18d01650b41e
Cr-Commit-Position: refs/heads/master@{#434508}

[vasilii, 2016-11-25 13:39:02]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 13:39:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-11-25 13:39:41]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-11-25 13:39:41]

Hi Vaclav,

please review.

[commit-bot: I haz the power, 2016-11-25 14:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 14:17:57]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-11-25 15:07:26]

LGTM assuming we clarify the question below.

Thanks,
Vaclav

https://codereview.chromium.org/2529093002/diff/1/chrome/browser/ui/views/pas...
File chrome/browser/ui/views/passwords/manage_password_items_view.cc (left):

https://codereview.chromium.org/2529093002/diff/1/chrome/browser/ui/views/pas...
chrome/browser/ui/views/passwords/manage_password_items_view.cc:274: if
(!password_form.is_public_suffix_match)
What about the following situation:

The user saves userA/pwd1 na http://1.chromium-test1.appspot.com/ and userB/pwd2
na http://2.chromium-test1.appspot.com/. Then the fill suggestions contain both
credentials on http://1.chromium-test1.appspot.com/, because although "userB" is
a PSL match and has a lower score than "userA", it has the best score among all
"userB" credentials. With your change on this line, would both these
credentials, including the PSL one, appear in the bubble?

[vasilii, 2016-11-25 15:25:19]

https://codereview.chromium.org/2529093002/diff/1/chrome/browser/ui/views/pas...
File chrome/browser/ui/views/passwords/manage_password_items_view.cc (left):

https://codereview.chromium.org/2529093002/diff/1/chrome/browser/ui/views/pas...
chrome/browser/ui/views/passwords/manage_password_items_view.cc:274: if
(!password_form.is_public_suffix_match)
On 2016/11/25 15:07:26, vabr (Chromium) wrote:
> What about the following situation:
> 
> The user saves userA/pwd1 na http://1.chromium-test1.appspot.com/ and
userB/pwd2
> na http://2.chromium-test1.appspot.com/. Then the fill suggestions contain
both
> credentials on http://1.chromium-test1.appspot.com/, because although "userB"
is
> a PSL match and has a lower score than "userA", it has the best score among
all
> "userB" credentials. With your change on this line, would both these
> credentials, including the PSL one, appear in the bubble?

To be fixed in another place because it's platform specific code. On Mac what
you described doesn't work properly.

[vasilii, 2016-11-25 15:25:45]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-11-25 15:26:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 15:29:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480087545192700, "parent_rev":
"4d1aad7d99436d03bd0b742e3381450b645d6880", "commit_rev":
"f9011641f9d968d1bd7a1ee8d5e258d8ff83fb8e"}

[commit-bot: I haz the power, 2016-11-25 15:29:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-25 15:32:42]

Description was changed from

==========
Hide PSL matches in the password bubble after the account chooser.

The PSL matches can be shown in the account chooser. The "Manage passwords"
bubble can appear after the dialog was dismissed. It should be empty because the
PSL matches aren't saved for the current site.

BUG=666340
==========

to

==========
Hide PSL matches in the password bubble after the account chooser.

The PSL matches can be shown in the account chooser. The "Manage passwords"
bubble can appear after the dialog was dismissed. It should be empty because the
PSL matches aren't saved for the current site.

BUG=666340

Committed: https://crrev.com/9fbb8593200ef0defadc83add39b18d01650b41e
Cr-Commit-Position: refs/heads/master@{#434508}
==========

[commit-bot: I haz the power, 2016-11-25 15:32:43]

Patchset 1 (id:??) landed as
https://crrev.com/9fbb8593200ef0defadc83add39b18d01650b41e
Cr-Commit-Position: refs/heads/master@{#434508}