Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2543)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2531863002: Delete all the traces of federation providers in the account chooser. (Closed)
Patch Set: android2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 66ed924d8a04f8d514e4bc30f2fb374a2317cd4f..30b714c9e1abe466800465853a7be796eeaa5d79 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -96,7 +96,6 @@ void ManagePasswordsUIController::OnUpdatePasswordSubmitted(
bool ManagePasswordsUIController::OnChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
- std::vector<std::unique_ptr<autofill::PasswordForm>> federated_credentials,
const GURL& origin,
const ManagePasswordsState::CredentialsCallback& callback) {
DCHECK(!local_credentials.empty());
@@ -109,17 +108,14 @@ bool ManagePasswordsUIController::OnChooseCredentials(
PasswordDialogController::FormsVector locals;
if (!local_credentials[0]->is_public_suffix_match)
locals = CopyFormVector(local_credentials);
- PasswordDialogController::FormsVector federations =
- CopyFormVector(federated_credentials);
- passwords_data_.OnRequestCredentials(
- std::move(locals), std::move(federations), origin);
+ passwords_data_.OnRequestCredentials(std::move(locals), origin);
passwords_data_.set_credentials_callback(callback);
dialog_controller_.reset(new PasswordDialogControllerImpl(
Profile::FromBrowserContext(web_contents()->GetBrowserContext()),
this));
dialog_controller_->ShowAccountChooser(
CreateAccountChooser(dialog_controller_.get()),
- std::move(local_credentials), std::move(federated_credentials));
+ std::move(local_credentials));
UpdateBubbleAndIconVisibility();
return true;
}
@@ -241,11 +237,6 @@ ManagePasswordsUIController::GetCurrentForms() const {
return passwords_data_.GetCurrentForms();
}
-const std::vector<std::unique_ptr<autofill::PasswordForm>>&
-ManagePasswordsUIController::GetFederatedForms() const {
- return passwords_data_.federation_providers_forms();
-}
-
const password_manager::InteractionsStats*
ManagePasswordsUIController::GetCurrentInteractionStats() const {
DCHECK_EQ(password_manager::ui::PENDING_PASSWORD_STATE, GetState());

Powered by Google App Engine
This is Rietveld 408576698