Expose the full API for attaching devtools clients:

Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953
Committed: https://crrev.com/0eebabe203d03e50b696b8834c6eeddbde4114e8
Cr-Commit-Position: refs/heads/master@{#434956}

[tmarek, 2016-11-28 15:16:46]

Description was changed from

==========
Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953
==========

to

==========
Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953
==========

[tmarek, 2016-11-28 15:16:47]

tmarek@google.com changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-11-28 16:58:13]

Looks great! Two small nits.

https://codereview.chromium.org/2531313002/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_devtools_client_impl.cc (right):

https://codereview.chromium.org/2531313002/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_devtools_client_impl.cc:78: } else {
nit: Chromium doesn't use "else" after "return":
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

https://codereview.chromium.org/2531313002/diff/1/headless/public/headless_de...
File headless/public/headless_devtools_target.h (right):

https://codereview.chromium.org/2531313002/diff/1/headless/public/headless_de...
headless/public/headless_devtools_target.h:35: // Returns true if a devtools
client is attaced.
typo: attached

[tmarek, 2016-11-29 10:14:59]

https://codereview.chromium.org/2531313002/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_devtools_client_impl.cc (right):

https://codereview.chromium.org/2531313002/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_devtools_client_impl.cc:78: } else {
On 2016/11/28 16:58:13, Sami wrote:
> nit: Chromium doesn't use "else" after "return":
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

Done.

https://codereview.chromium.org/2531313002/diff/1/headless/public/headless_de...
File headless/public/headless_devtools_target.h (right):

https://codereview.chromium.org/2531313002/diff/1/headless/public/headless_de...
headless/public/headless_devtools_target.h:35: // Returns true if a devtools
client is attaced.
On 2016/11/28 16:58:13, Sami wrote:
> typo: attached

Done.

[Sami, 2016-11-29 10:28:23]

Thanks, lgtm!

[tmarek, 2016-11-29 10:48:43]

The CQ bit was checked by tmarek@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 10:48:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 10:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 10:57:04]

Dry run: This issue passed the CQ dry run.

[tmarek, 2016-11-29 10:57:48]

The CQ bit was checked by tmarek@google.com

[commit-bot: I haz the power, 2016-11-29 10:58:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 11:03:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480417068366910,
"parent_rev": "b069a9968da676367d7872264bd18434135f922c", "commit_rev":
"97d97a2341b3657d828f4e1b5ae0e5a683a7ee5e"}

[commit-bot: I haz the power, 2016-11-29 11:03:32]

Description was changed from

==========
Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953
==========

to

==========
Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953
==========

[commit-bot: I haz the power, 2016-11-29 11:03:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 11:05:29]

Description was changed from

==========
Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953
==========

to

==========
Expose the full API for attaching devtools clients:

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953

Committed: https://crrev.com/0eebabe203d03e50b696b8834c6eeddbde4114e8
Cr-Commit-Position: refs/heads/master@{#434956}
==========

[commit-bot: I haz the power, 2016-11-29 11:05:30]

Patchset 2 (id:??) landed as
https://crrev.com/0eebabe203d03e50b696b8834c6eeddbde4114e8
Cr-Commit-Position: refs/heads/master@{#434956}