headless/lib/browser/headless_web_contents_impl.h - Issue 2531313002: Expose the full API for attaching devtools clients:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_web_contents_impl.h

Issue 2531313002: Expose the full API for attaching devtools clients: (Closed)

Patch Set: Addressed code review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_web_contents_impl.h

diff --git a/headless/lib/browser/headless_web_contents_impl.h b/headless/lib/browser/headless_web_contents_impl.h

index d7abd377a72a0a7fab0b4407697c41e370281c88..2e9a9b96e54925b2bcd7eee91ba5cd022eb3a72b 100644

--- a/headless/lib/browser/headless_web_contents_impl.h

+++ b/headless/lib/browser/headless_web_contents_impl.h

@@ -58,8 +58,10 @@ class HeadlessWebContentsImpl : public HeadlessWebContents,

HeadlessDevToolsTarget* GetDevToolsTarget() override;

// HeadlessDevToolsTarget implementation:

- void AttachClient(HeadlessDevToolsClient* client) override;

+ bool AttachClient(HeadlessDevToolsClient* client) override;

+ void ForceAttachClient(HeadlessDevToolsClient* client) override;

void DetachClient(HeadlessDevToolsClient* client) override;

+ bool IsAttached() override;

// RenderProcessHostObserver implementation:

void RenderProcessExited(content::RenderProcessHost* host,