Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: headless/public/headless_devtools_target.h

Issue 2531313002: Expose the full API for attaching devtools clients: (Closed)
Patch Set: Addressed code review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/headless_devtools_client_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/headless_devtools_target.h
diff --git a/headless/public/headless_devtools_target.h b/headless/public/headless_devtools_target.h
index 941fe6f51e2ae640e9462d015f5c646005eebc5e..e8047f39b8f131432fed075bf8ac0222ac9c613c 100644
--- a/headless/public/headless_devtools_target.h
+++ b/headless/public/headless_devtools_target.h
@@ -20,14 +20,21 @@ class HEADLESS_EXPORT HeadlessDevToolsTarget {
// Attach or detach a client to this target. A client must be attached in
// order to send commands or receive notifications from the target.
//
- // A single client may be attached to at most one target at a time. Note that
- // currently also only one client may be attached to a single target at a
- // time.
+ // A single client may be attached to at most one target at a time. If
+ // the target already has a client attached, AttachClient will return false.
+ // ForceAttachClient will detach any existing connection before attaching
+ // |client|.
+ // Note that currently also only one client may be attached to a single target
+ // at a time.
//
// |client| must outlive this target.
- virtual void AttachClient(HeadlessDevToolsClient* client) = 0;
+ virtual bool AttachClient(HeadlessDevToolsClient* client) = 0;
+ virtual void ForceAttachClient(HeadlessDevToolsClient* client) = 0;
virtual void DetachClient(HeadlessDevToolsClient* client) = 0;
+ // Returns true if a devtools client is attached.
+ virtual bool IsAttached() = 0;
+
private:
DISALLOW_COPY_AND_ASSIGN(HeadlessDevToolsTarget);
};
« no previous file with comments | « headless/lib/headless_devtools_client_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698