headless/lib/browser/headless_devtools_client_impl.h - Issue 2531313002: Expose the full API for attaching devtools clients:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_devtools_client_impl.h

Issue 2531313002: Expose the full API for attaching devtools clients: (Closed)

Patch Set: Addressed code review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_devtools_client_impl.h

diff --git a/headless/lib/browser/headless_devtools_client_impl.h b/headless/lib/browser/headless_devtools_client_impl.h

index ddc59c4c15b9f49e5e7c7fea081a70e1f53dd5ea..a9e270a4b4ff527dc2e21c0881104bc4fb98348c 100644

--- a/headless/lib/browser/headless_devtools_client_impl.h

+++ b/headless/lib/browser/headless_devtools_client_impl.h

@@ -115,7 +115,8 @@ class HeadlessDevToolsClientImpl : public HeadlessDevToolsClient,

const char* method,

base::Callback<void(const base::Value&)> callback) override;

- void AttachToHost(content::DevToolsAgentHost* agent_host);

+ bool AttachToHost(content::DevToolsAgentHost* agent_host);

+ void ForceAttachToHost(content::DevToolsAgentHost* agent_host);

void DetachFromHost(content::DevToolsAgentHost* agent_host);

private:

« no previous file with comments | « no previous file | headless/lib/browser/headless_devtools_client_impl.cc » ('j') | no next file with comments »