Use VrClassesBuilder to reduce reflection usage

Use VrClassesBuilder to reduce reflection usage

BUG=664269
Committed: https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83
Cr-Commit-Position: refs/heads/master@{#434801}

[bshe, 2016-11-24 19:03:43]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 19:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 20:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 20:10:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bshe, 2016-11-25 15:32:09]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 15:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bshe, 2016-11-25 15:39:07]

bshe@chromium.org changed reviewers:
+ agrieve@chromium.org

[bshe, 2016-11-25 15:39:08]

Hi Andrew. Per your suggestion, this CL reduced the usage of reflection in
vr_shell to one. PTAL, thanks!

[agrieve, 2016-11-25 16:19:12]

Looks great! Thanks.

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
(right):

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:21:
public VrCoreVersionCheckerImpl() {
nit: can remove this

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:141:
mVrClassesBuilder = null;
nit: null assignment shouldn't be necessary.

[agrieve, 2016-11-25 16:19:19]

On 2016/11/25 16:19:12, agrieve wrote:
> Looks great! Thanks.
> 
>
https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
> (right):
> 
>
https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:21:
> public VrCoreVersionCheckerImpl() {
> nit: can remove this
> 
>
https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
> (right):
> 
>
https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:141:
> mVrClassesBuilder = null;
> nit: null assignment shouldn't be necessary.

lgtm

[commit-bot: I haz the power, 2016-11-25 16:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 16:49:05]

Dry run: This issue passed the CQ dry run.

[bshe, 2016-11-28 14:23:41]

Thanks

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
(right):

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java:21:
public VrCoreVersionCheckerImpl() {
On 2016/11/25 16:19:12, agrieve wrote:
> nit: can remove this

Done.

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2530923002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:141:
mVrClassesBuilder = null;
On 2016/11/25 16:19:12, agrieve wrote:
> nit: null assignment shouldn't be necessary.

Done.

[bshe, 2016-11-28 14:23:47]

The CQ bit was checked by bshe@chromium.org

[bshe, 2016-11-28 14:23:47]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2530923002/#ps40001
(title: "Reviews")

[commit-bot: I haz the power, 2016-11-28 14:24:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 17:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 17:27:48]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java:12
  error:
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
index
8fad10f7a60e555efd5875fdba23814e3a49b708..b8f58e3f802630cec479c65d42b4dcb2393fddb2
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
@@ -12,17 +12,13 @@ import android.content.Intent;
 import com.google.vr.ndk.base.AndroidCompat;
 import com.google.vr.ndk.base.DaydreamApi;
 
-import org.chromium.base.annotations.UsedByReflection;
-
 /**
  * A wrapper for DaydreamApi. Note that we have to recreate the DaydreamApi
instance each time we
  * use it, or API calls begin to silently fail.
  */
-@UsedByReflection("VrShellDelegate.java")
 public class VrDaydreamApiImpl implements VrDaydreamApi {
     private final Activity mActivity;
 
-    @UsedByReflection("VrShellDelegate.java")
     public VrDaydreamApiImpl(Activity activity) {
         mActivity = activity;
     }

[bshe, 2016-11-28 19:15:28]

The CQ bit was checked by bshe@chromium.org

[bshe, 2016-11-28 19:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2530923002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-28 19:16:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:28:24]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[bshe, 2016-11-28 23:04:57]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:46:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480374297976950,
"parent_rev": "bf2f7ddd21fbad444594b694355d9e843c17eb8f", "commit_rev":
"0f059f102347e24d44e211b82ca68e5bec7c0fbf"}

[commit-bot: I haz the power, 2016-11-29 00:46:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-29 00:55:54]

Description was changed from

==========
Use VrClassesBuilder to reduce reflection usage

BUG=664269
==========

to

==========
Use VrClassesBuilder to reduce reflection usage

BUG=664269

Committed: https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83
Cr-Commit-Position: refs/heads/master@{#434801}
==========

[commit-bot: I haz the power, 2016-11-29 00:55:55]

Patchset 4 (id:??) landed as
https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83
Cr-Commit-Position: refs/heads/master@{#434801}