chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java - Issue 2530923002: Use VrClassesBuilder to reduce reflection usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java

Issue 2530923002: Use VrClassesBuilder to reduce reflection usage (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java

index 909ea3ee0a521d130ec20a79027df9b252358c5f..f45501a6bb0bb1f1fb358026a0864c4a73b88d05 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java

@@ -13,17 +13,13 @@ import com.google.vr.ndk.base.AndroidCompat;

import com.google.vr.ndk.base.DaydreamApi;

import com.google.vr.ndk.base.GvrApi;

-import org.chromium.base.annotations.UsedByReflection;

/**

* A wrapper for DaydreamApi. Note that we have to recreate the DaydreamApi instance each time we

* use it, or API calls begin to silently fail.

-@UsedByReflection("VrShellDelegate.java")

public class VrDaydreamApiImpl implements VrDaydreamApi {

private final Activity mActivity;

- @UsedByReflection("VrShellDelegate.java")

public VrDaydreamApiImpl(Activity activity) {

mActivity = activity;

}