chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java - Issue 2530923002: Use VrClassesBuilder to reduce reflection usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java

Issue 2530923002: Use VrClassesBuilder to reduce reflection usage (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java

index 4715015877fce3d5812d4b542375b32ad13a6d05..b363eff8f80e3e9826ee0479a511a745ba7cf945 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java

@@ -11,19 +11,13 @@ import com.google.vr.vrcore.base.api.VrCoreUtils.ConnectionResult;

import org.chromium.base.ContextUtils;

import org.chromium.base.Log;

-import org.chromium.base.annotations.UsedByReflection;

/**

* Helper class to check if VrCore version is compatible with Chromium.

-@UsedByReflection("VrShellDelegate.java")

public class VrCoreVersionCheckerImpl implements VrCoreVersionChecker {

private static final String TAG = "VrCoreVersionChecker";

- @UsedByReflection("VrShellDelegate.java")

- public VrCoreVersionCheckerImpl() {

- }

@Override

public boolean isVrCoreCompatible() {

try {