Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2530923002: Use VrClassesBuilder to reduce reflection usage (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
index 9e054ec8ee53cf125cdf5080fe87cbe5be2a8285..a82509e3623c9450ea2da01f2959a6d1b4e9d276 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
@@ -30,7 +30,6 @@ import com.google.vr.ndk.base.GvrLayout;
import org.chromium.base.CommandLine;
import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.JNINamespace;
-import org.chromium.base.annotations.UsedByReflection;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ChromeVersionInfo;
import org.chromium.chrome.browser.WebContentsFactory;
@@ -49,13 +48,9 @@ import javax.microedition.khronos.opengles.GL10;
* This view extends from GvrLayout which wraps a GLSurfaceView that renders VR shell.
*/
@JNINamespace("vr_shell")
-@UsedByReflection("VrShellDelegate.java")
public class VrShellImpl extends GvrLayout implements GLSurfaceView.Renderer, VrShell {
private static final String TAG = "VrShellImpl";
- @UsedByReflection("VrShellDelegate.java")
- public static final String VR_EXTRA = "android.intent.extra.VR_LAUNCH";
-
private Activity mActivity;
private final GLSurfaceView mGlSurfaceView;
@@ -88,7 +83,6 @@ public class VrShellImpl extends GvrLayout implements GLSurfaceView.Renderer, Vr
private ContentViewCore mUiCVC;
private VrWindowAndroid mUiVrWindowAndroid;
- @UsedByReflection("VrShellDelegate.java")
public VrShellImpl(Activity activity) {
super(activity);
mActivity = activity;
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698