Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 252923002: Get rid of PageSet.FromDict from unittests (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Get rid of PageSet.FromDict from unittests BUG=239179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -194 lines) Patch
M tools/perf/measurements/timeline_based_measurement_unittest.py View 1 chunk +3 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py View 1 chunk +5 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py View 1 chunk +5 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py View 1 chunk +4 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py View 1 chunk +5 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_results_unittest.py View 1 chunk +5 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_results_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 chunk +36 lines, -73 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 1 chunk +4 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/value_unittest_.py View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 7 months ago (2014-04-28 17:01:40 UTC) #1
tonyg
lgtm Very clean!
6 years, 7 months ago (2014-04-28 17:18:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/252923002/1
6 years, 7 months ago (2014-04-28 17:18:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 17:22:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 17:22:25 UTC) #5
dtu
so lgtm much cleanup
6 years, 7 months ago (2014-04-28 18:42:07 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 19:56:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/252923002/1
6 years, 7 months ago (2014-04-28 19:57:23 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 23:45:52 UTC) #9
Message was sent while issue was closed.
Change committed as 266693

Powered by Google App Engine
This is Rietveld 408576698