tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py - Issue 252923002: Get rid of PageSet.FromDict from unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

Issue 252923002: Get rid of PageSet.FromDict from unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/measurements/timeline_based_measurement_unittest.py ('k') | tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

index a0355fc9d0806ff23a5a3d7990b5bca488709e33..234aa01596a9e8a5d39bdbedb1ff88ae6ee0122d 100644

--- a/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/page/block_page_measurement_results_unittest.py

@@ -12,14 +12,11 @@ BlockPageMeasurementResults = \

block_page_measurement_results.BlockPageMeasurementResults

def _MakePageSet():

- return page_set.PageSet.FromDict({

- "description": "hello",

- "archive_path": "foo.wpr",

- "pages": [

- {"url": "http://www.foo.com/"},

- {"url": "http://www.bar.com/"}

- ]

- }, os.path.dirname(__file__))

+ ps = page_set.PageSet(file_path=os.path.dirname(__file__))

+ ps.AddPageWithDefaultRunNavigate('http://www.foo.com/')

+ ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')

+ return ps

class NonPrintingBlockPageMeasurementResults(BlockPageMeasurementResults):

def __init__(self, *args):