Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py

Issue 252923002: Get rid of PageSet.FromDict from unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py
diff --git a/tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py b/tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py
index c54ca26306e77cc5378dbf47f5535f7e78657a20..88f42e64115ff35735ac1e8256d4ac646dde53e3 100644
--- a/tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py
+++ b/tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py
@@ -10,15 +10,10 @@ from telemetry.value import list_of_scalar_values
class TestBase(unittest.TestCase):
def setUp(self):
- self.page_set = page_set.PageSet.FromDict({
- "description": "hello",
- "archive_path": "foo.wpr",
- "pages": [
- {"url": "http://www.bar.com/"},
- {"url": "http://www.baz.com/"},
- {"url": "http://www.foo.com/"}
- ]
- }, os.path.dirname(__file__))
+ self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
@property
def pages(self):

Powered by Google App Engine
This is Rietveld 408576698