Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: tools/telemetry/telemetry/value/value_unittest_.py

Issue 252923002: Get rid of PageSet.FromDict from unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/string_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/value_unittest_.py
diff --git a/tools/telemetry/telemetry/value/value_unittest_.py b/tools/telemetry/telemetry/value/value_unittest_.py
index 77e2569ab957533aab96352165550eff37182ce9..20468b4620111bd35cdc75751a562530435d0a88 100644
--- a/tools/telemetry/telemetry/value/value_unittest_.py
+++ b/tools/telemetry/telemetry/value/value_unittest_.py
@@ -9,15 +9,10 @@ from telemetry.page import page_set
class TestBase(unittest.TestCase):
def setUp(self):
- self.page_set = page_set.PageSet.FromDict({
- "description": "hello",
- "archive_path": "foo.wpr",
- "pages": [
- {"url": "http://www.bar.com/"},
- {"url": "http://www.baz.com/"},
- {"url": "http://www.foo.com/"}
- ]
- }, os.path.dirname(__file__))
+ self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
@property
def pages(self):
« no previous file with comments | « tools/telemetry/telemetry/value/string_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698