Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2527933002: Do not sort named parameters on FunctionNode. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not sort named parameters on FunctionNode. This was originally done to be consistent with FunctionType, where the named parameters are sorted, but for FunctionNode it is not necessary. It causes issues for natives that expect parameters to be declared in a certain order. It is also an issue if we ever want to reuse the kernel format for summaries, where it is also preferable to present the named parameters in their original order. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/963e1ebc55b0689b0d049a2ea34a6d39204ed6f5

Patch Set 1 #

Patch Set 2 : Also update functionType getter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 1 4 chunks +8 lines, -16 lines 0 comments Download
M pkg/kernel/lib/checks.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/kernel/testcases/spec-mode/named_parameters.baseline.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/named_parameters.baseline.txt View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/kernel/testcases/type-propagation/named_parameters.baseline.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
asgerf
4 years ago (2016-11-24 13:28:54 UTC) #4
Kevin Millikin (Google)
LGTM.
4 years ago (2016-11-25 09:51:19 UTC) #5
asgerf
4 years ago (2016-11-25 10:22:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
963e1ebc55b0689b0d049a2ea34a6d39204ed6f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698