Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2529973002: Speed up kernel sanity checks. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Speed up kernel sanity checks. Sanity checks now run in a single pass rather than two, and instead of building a set consisting of all members, it uses a bit from the transformer flags to remember which members are not orphaned. As an additional check, it now checks that members are not declared more than once. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/084bd8add28dea0d25bff2015a1cdfd59bc9405b

Patch Set 1 #

Patch Set 2 : Add back CheckParentPointers, dart2js/kernel uses it #

Patch Set 3 : Revert parent_pointer_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -52 lines) Patch
M pkg/kernel/bin/dartk.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/kernel/bin/transform.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/kernel/lib/checks.dart View 1 3 chunks +68 lines, -49 lines 0 comments Download
M pkg/kernel/lib/transformations/flags.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/kernel/test/check_bench.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years ago (2016-11-24 15:55:51 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years ago (2016-11-25 09:53:57 UTC) #3
asgerf
4 years ago (2016-11-25 11:02:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
084bd8add28dea0d25bff2015a1cdfd59bc9405b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698