Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: pkg/kernel/lib/analyzer/ast_from_analyzer.dart

Issue 2527933002: Do not sort named parameters on FunctionNode. (Closed)
Patch Set: Also update functionType getter Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_visitor.dart ('k') | pkg/kernel/lib/ast.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/analyzer/ast_from_analyzer.dart
diff --git a/pkg/kernel/lib/analyzer/ast_from_analyzer.dart b/pkg/kernel/lib/analyzer/ast_from_analyzer.dart
index 63132336881c4c7e7c0c2e45c233d068721ed8ea..9847b5987d91e16fc620094b6d6d34c1e452633c 100644
--- a/pkg/kernel/lib/analyzer/ast_from_analyzer.dart
+++ b/pkg/kernel/lib/analyzer/ast_from_analyzer.dart
@@ -457,9 +457,6 @@ class TypeScope extends ReferenceScope {
break;
}
}
- if (named.isNotEmpty) {
- sortAndRemoveDuplicates(named);
- }
var returnType = element is ConstructorElement
? const ast.VoidType()
: buildType(element.returnType);
@@ -561,9 +558,6 @@ class ExpressionScope extends TypeScope {
break;
}
}
- if (named.isNotEmpty) {
- sortAndRemoveDuplicates(named);
- }
return new ast.FunctionNode(buildOptionalFunctionBody(body),
typeParameters: typeParameters,
positionalParameters: positional,
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_visitor.dart ('k') | pkg/kernel/lib/ast.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698