Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2105)

Unified Diff: pkg/kernel/lib/checks.dart

Issue 2527933002: Do not sort named parameters on FunctionNode. (Closed)
Patch Set: Also update functionType getter Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/testcases/spec-mode/named_parameters.baseline.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/checks.dart
diff --git a/pkg/kernel/lib/checks.dart b/pkg/kernel/lib/checks.dart
index a450e2f3d68f0faafdc713af95077bd6db13650f..3d9a8651d1422f8a4fcac5e0d1e672c2abf2d614 100644
--- a/pkg/kernel/lib/checks.dart
+++ b/pkg/kernel/lib/checks.dart
@@ -75,11 +75,6 @@ class CheckReferences extends RecursiveVisitor {
}
visitFunctionNode(FunctionNode node) {
- for (int i = 1; i < node.namedParameters.length; ++i) {
- if (node.namedParameters[i - 1].compareTo(node.namedParameters[i]) >= 0) {
- throw 'Named parameters are not sorted on function found in $context';
- }
- }
typeParameters.addAll(node.typeParameters);
node.visitChildren(this);
typeParameters.removeAll(node.typeParameters);
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/testcases/spec-mode/named_parameters.baseline.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698