[wasm] [asmjs] Route asm.js warnings to the dev console.

[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive, using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chromium.org,jochen@chromium.org

Committed: https://crrev.com/aabbbec67c3c7363ef08c657f2d688ad2e8f7de8
Cr-Commit-Position: refs/heads/master@{#41648}

[bradnelson, 2016-11-23 07:45:41]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 07:45:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-11-23 07:47:15]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emit asm.js warning
messages.
In Blink, this will route to the developer console.

BUG=v8:4203
BUG=660016
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

BUG=v8:4203
BUG=660016
==========

[bradn, 2016-11-23 07:49:19]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

BUG=v8:4203
BUG=660016
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
==========

[bradn, 2016-11-23 07:51:54]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
R=dgozman@chromium.org,danno@chromium.org
==========

[bradn, 2016-11-23 07:53:22]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
R=dgozman@chromium.org,danno@chromium.org
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org
==========

[bradn, 2016-11-23 07:53:22]

bradnelson@google.com changed reviewers:
+ danno@chromium.org, dgozman@chromium.org, machenbach@chromium.org

[bradn, 2016-11-23 08:14:30]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

[bradn, 2016-11-23 08:14:30]

bradnelson@google.com changed reviewers:
+ bmeurer@chromium.org

[bradn, 2016-11-23 08:15:00]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-11-23 08:15:00]

PTSL

[bradn, 2016-11-23 08:15:15]

PTAL rather...

[Michael Hablich, 2016-11-23 08:17:08]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203
BUG=660016
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203,chromium:660016
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

[commit-bot: I haz the power, 2016-11-23 08:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 08:34:41]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-11-23 08:36:52]

Blink side: https://codereview.chromium.org/2530503002/

[Benedikt Meurer, 2016-11-23 08:41:31]

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc#newcode403
src/api.cc:403: if (i::FLAG_disable_asm_warnings) {
Is this flag really useful? If you don't want the warnings, it's probably fine
to not install a handler?

[bradn, 2016-11-23 08:46:18]

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc#newcode403
src/api.cc:403: if (i::FLAG_disable_asm_warnings) {
On 2016/11/23 08:41:31, Benedikt Meurer wrote:
> Is this flag really useful? If you don't want the warnings, it's probably fine
> to not install a handler?

machenbach, how is the correctness fuzzer set up?
Is this flag useful for it?
(It's not yet checked in anywhere, so I was unsure whether it runs d8 or is set
up as a libfuzzer).

[Michael Achenbach, 2016-11-23 09:01:22]

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc#newcode403
src/api.cc:403: if (i::FLAG_disable_asm_warnings) {
On 2016/11/23 08:46:18, bradn wrote:
> On 2016/11/23 08:41:31, Benedikt Meurer wrote:
> > Is this flag really useful? If you don't want the warnings, it's probably
fine
> > to not install a handler?
> 
> machenbach, how is the correctness fuzzer set up?
> Is this flag useful for it?
> (It's not yet checked in anywhere, so I was unsure whether it runs d8 or is
set
> up as a libfuzzer).

It runs d8. But maybe already https://codereview.chromium.org/2523703002 would
be enough. I already suppress the warnings by line. The problem were the missing
newlines. If that's fixed I'd just ignore those lines anyways.

[bradn, 2016-11-23 09:10:40]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

Add --disable-asm-warnings to allow suppression of asm warnings (for correctness
fuzzer).

BUG=v8:4203,chromium:660016
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

[bradnelson, 2016-11-23 09:10:48]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[bradn, 2016-11-23 09:10:56]

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2526703002/diff/20001/src/api.cc#newcode403
src/api.cc:403: if (i::FLAG_disable_asm_warnings) {
On 2016/11/23 09:01:22, machenbach (slow) wrote:
> On 2016/11/23 08:46:18, bradn wrote:
> > On 2016/11/23 08:41:31, Benedikt Meurer wrote:
> > > Is this flag really useful? If you don't want the warnings, it's probably
> fine
> > > to not install a handler?
> > 
> > machenbach, how is the correctness fuzzer set up?
> > Is this flag useful for it?
> > (It's not yet checked in anywhere, so I was unsure whether it runs d8 or is
> set
> > up as a libfuzzer).
> 
> It runs d8. But maybe already https://codereview.chromium.org/2523703002 would
> be enough. I already suppress the warnings by line. The problem were the
missing
> newlines. If that's fixed I'd just ignore those lines anyways.
Ok.
Dropped until we know we need it.

[commit-bot: I haz the power, 2016-11-23 09:10:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 09:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 09:38:57]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-11-29 06:39:20]

Ping?

[Benedikt Meurer, 2016-11-29 06:40:36]

LGTM.

[dgozman, 2016-11-29 19:00:53]

https://codereview.chromium.org/2526703002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2526703002/diff/40001/include/v8.h#newcode7075
include/v8.h:7075: void SetAsmJsWarningHandler(AsmJsWarningCallback that);
Do we really need this to be asm-js specific? What about SetWarninghandler, or
even (similar to message handler) {Add,Remove}WarningHandler?

[bradnelson, 2016-12-01 00:00:18]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 00:00:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 00:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 00:08:15]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[bradnelson, 2016-12-01 01:37:20]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:37:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 01:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:46:35]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[bradnelson, 2016-12-01 09:20:12]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 09:20:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-12-01 09:32:30]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Add a callback exposed to embedders that emits asm.js warning
messages.
In Blink, this will route to the developer console.

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

[bradnelson, 2016-12-01 09:32:48]

PTAL

Now sharing Message as discussed.

[bradnelson, 2016-12-01 09:49:30]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

[bradnelson, 2016-12-01 09:49:30]

bradnelson@chromium.org changed reviewers:
+ jochen@chromium.org

[bradnelson, 2016-12-01 09:49:54]

+jochen, just realized he was only on the other half of the change.

[commit-bot: I haz the power, 2016-12-01 09:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 09:52:02]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-01 18:39:36]

API looks good to me, but I don't have enough knowledge to judge the
implementation. Don't we need some tests for this?

[jochen (gone - plz use gerrit), 2016-12-05 15:42:20]

I'm still somewhat saddened that we have to add so much API instead of just
adding the message to the console directly.

[bradnelson, 2016-12-12 13:19:12]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:19:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-12-12 13:19:45]

Added tests.
PTAL

[jochen (gone - plz use gerrit), 2016-12-12 13:21:12]

lgtm

[commit-bot: I haz the power, 2016-12-12 13:23:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 13:23:34]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[bradnelson, 2016-12-12 13:40:44]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 13:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 14:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 14:08:57]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-12-12 14:11:20]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-12-12 14:11:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2526703002/#ps150001
(title: "merge")

[commit-bot: I haz the power, 2016-12-12 14:11:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 14:47:58]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1481551880677030,
"parent_rev": "0885c5916010ab3995929a87de2a8e233f5d8a76", "commit_rev":
"27afcf3f76ad41e7ce38f9a91b0a747907511892"}

[commit-bot: I haz the power, 2016-12-12 14:48:03]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...

Review-Url: https://codereview.chromium.org/2526703002
==========

[commit-bot: I haz the power, 2016-12-12 14:48:05]

Committed patchset #9 (id:150001)

[commit-bot: I haz the power, 2016-12-12 14:48:59]

Description was changed from

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...

Review-Url: https://codereview.chromium.org/2526703002
==========

to

==========
[wasm] [asmjs] Route asm.js warnings to the dev console.

Generalize Messages to include an error level.
Add a parameter to AddMessageHandler to select which error levels to receive,
using a mask (default being just errors, i.e. the current behavior).

BUG=v8:4203
R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chr...

Committed: https://crrev.com/aabbbec67c3c7363ef08c657f2d688ad2e8f7de8
Cr-Commit-Position: refs/heads/master@{#41648}
==========

[commit-bot: I haz the power, 2016-12-12 14:49:01]

Patchset 9 (id:??) landed as
https://crrev.com/aabbbec67c3c7363ef08c657f2d688ad2e8f7de8
Cr-Commit-Position: refs/heads/master@{#41648}