[wasm] [asmjs] Route asm.js warnings to the dev console.

src/asmjs/asm-typer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/asmjs/asm-typer.h"
 
 #include <algorithm>
 #include <limits>
 #include <memory>
 #include <string>
 
+#include "include/v8.h"
 #include "src/v8.h"
 
 #include "src/asmjs/asm-types.h"
 #include "src/ast/ast.h"
 #include "src/ast/scopes.h"
 #include "src/base/bits.h"
 #include "src/codegen.h"
 #include "src/globals.h"
+#include "src/messages.h"
 #include "src/utils.h"
 
-#define FAIL_LINE(line, msg)                                   \
-  do {                                                         \
-    base::OS::SNPrintF(error_message_, sizeof(error_message_), \
-                       "asm: line %d: %s", (line) + 1, msg);   \
-    return AsmType::None();                                    \
+#define FAIL_LOCATION(location, msg)                                      \
+  do {                                                                    \
+    Handle<String> message(isolate_->factory()->InternalizeOneByteString( \
+        STATIC_CHAR_VECTOR(msg)));                                        \
+    error_message_ = MessageHandler::MakeMessageObject(                   \
+        isolate_, MessageTemplate::kAsmJsInvalid, (location), message,    \
+        Handle<JSArray>::null());                                         \
+    error_message_->set_error_level(v8::Isolate::kMessageWarning);        \
+    message_location_ = *(location);                                      \
+    return AsmType::None();                                               \
   } while (false)
 
-#define FAIL(node, msg)                                        \
-  do {                                                         \
-    int line = node->position() == kNoSourcePosition           \
-                   ? -1                                        \
-                   : script_->GetLineNumber(node->position()); \
-    FAIL_LINE(line, msg);                                      \
+#define FAIL(node, msg)                                                    \
+  do {                                                                     \
+    MessageLocation location(script_, node->position(), node->position()); \
+    FAIL_LOCATION(&location, msg);                                         \
   } while (false)
 
 #define RECURSE(call)                                             \
   do {                                                            \
     if (GetCurrentStackPosition() < stack_limit_) {               \
       stack_overflow_ = true;                                     \
       FAIL(root_, "Stack overflow while parsing asm.js module."); \
     }                                                             \
                                                                   \
     AsmType* result = (call);                                     \
@@ skipping 112 matching lines @@
 
 AsmTyper::VariableInfo* AsmTyper::VariableInfo::Clone(Zone* zone) const {
   CHECK(standard_member_ != kNone);
   CHECK(!type_->IsA(AsmType::None()));
   auto* new_var_info = new (zone) VariableInfo(type_);
   new_var_info->standard_member_ = standard_member_;
   new_var_info->mutability_ = mutability_;
   return new_var_info;
 }
 
-void AsmTyper::VariableInfo::SetFirstForwardUse(int source_location) {
-  DCHECK(source_location_ == -1);
+void AsmTyper::VariableInfo::SetFirstForwardUse(
+    const MessageLocation& source_location) {
   missing_definition_ = true;
   source_location_ = source_location;
 }
 
 // ----------------------------------------------------------------------------
 // Implementation of AsmTyper
 
 AsmTyper::AsmTyper(Isolate* isolate, Zone* zone, Handle<Script> script,
                    FunctionLiteral* root)
     : isolate_(isolate),
@@ skipping 214 matching lines @@
 
   if (entry == nullptr && !module_name_.is_null() &&
       module_name_->Equals(*variable->name())) {
     return module_info_;
   }
 
   return entry ? reinterpret_cast<VariableInfo*>(entry->value) : nullptr;
 }
 
 void AsmTyper::AddForwardReference(VariableProxy* proxy, VariableInfo* info) {
-  info->SetFirstForwardUse(proxy->position());
+  MessageLocation location(script_, proxy->position(), proxy->position());
+  info->SetFirstForwardUse(location);
   forward_definitions_.push_back(info);
 }
 
 bool AsmTyper::AddGlobal(Variable* variable, VariableInfo* info) {
   // We can't DCHECK(!in_function_) because function may actually install global
   // names (forward defined functions and function tables.)
   DCHECK(info->mutability() != VariableInfo::kInvalidMutability);
   DCHECK(info->IsGlobal());
   DCHECK(ValidAsmIdentifier(variable->name()));
 
@@ skipping 317 matching lines @@
     }
   }
 
   // 6.2 ValidateExport
   if (module_return_ == nullptr) {
     FAIL(fun, "Missing asm.js module export.");
   }
 
   for (auto* forward_def : forward_definitions_) {
     if (forward_def->missing_definition()) {
-      int position = forward_def->source_location();
-      int line =
-          position == kNoSourcePosition ? -1 : script_->GetLineNumber(position);
-
-      FAIL_LINE(line, "Missing definition for forward declared identifier.");
+      FAIL_LOCATION(forward_def->source_location(),
+                    "Missing definition for forward declared identifier.");
     }
   }
 
   RECURSE(ValidateExport(module_return_));
 
   if (!source_layout_.IsValid()) {
     FAIL(fun, "Invalid asm.js source code layout.");
   }
 
   return AsmType::Int();  // Any type that is not AsmType::None();
@@ skipping 2142 matching lines @@
 
   if (!heap_var_info->IsHeap()) {
     FAIL(heap,
          "Heap view creation parameter should be the module's heap parameter.");
   }
 
   DCHECK(heap_view_info->type()->IsA(AsmType::Heap()));
   return heap_view_info->type();
 }
 
-bool IsValidAsm(Isolate* isolate, Zone* zone, Handle<Script> script,
-                FunctionLiteral* root, std::string* error_message) {
-  error_message->clear();
-
-  AsmTyper typer(isolate, zone, script, root);
-  if (typer.Validate()) {
-    return true;
-  }
-
-  *error_message = typer.error_message();
-  return false;
-}
-
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8