Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2523703002: [asmjs] Avoid truncation of error messages (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asmjs] Avoid truncation of error messages We had error messages that exceeded the current limit of 100 characters, resulting in the newline being cut off. This CL also reverts http://crrev.com/2503423006 since it did not fix this issue. BUG=chromium:660016 R=machenbach@chromium.org, titzer@chromium.org Committed: https://crrev.com/332b9b584283d583f6f283984115426540180128 Cr-Commit-Position: refs/heads/master@{#41192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/asmjs/asm-js.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/asmjs/asm-typer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/asmjs/asm-typer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Achenbach
lgtm
4 years, 1 month ago (2016-11-22 13:41:50 UTC) #5
bradnelson
lgtm lgtm!
4 years, 1 month ago (2016-11-22 17:15:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523703002/1
4 years, 1 month ago (2016-11-22 17:15:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 17:17:41 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:18:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/332b9b584283d583f6f283984115426540180128
Cr-Commit-Position: refs/heads/master@{#41192}

Powered by Google App Engine
This is Rietveld 408576698