Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2523473002: [cleanup] Drop handwritten KeyedStoreIC code (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Drop handwritten KeyedStoreIC code The handwritten-assembly implementations of both dispatcher and generic stub have been replaced by Turbofan-generated stubs. Committed: https://crrev.com/5ef05d8e2c4c46f6a0c65544a1857c4f08a23176 Cr-Commit-Position: refs/heads/master@{#41188}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10875 lines) Patch
M BUILD.gn View 1 9 chunks +0 lines, -18 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -232 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +0 lines, -331 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 4 chunks +0 lines, -52 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +0 lines, -132 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +0 lines, -266 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 3 chunks +0 lines, -110 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -21 lines 0 comments Download
M src/code-stubs.h View 4 chunks +0 lines, -45 lines 0 comments Download
M src/codegen.h View 1 chunk +0 lines, -37 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -323 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +0 lines, -42 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +0 lines, -120 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +0 lines, -275 lines 0 comments Download
D src/ic/arm/ic-compiler-arm.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D src/ic/arm/stub-cache-arm.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D src/ic/arm64/ic-compiler-arm64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D src/ic/arm64/stub-cache-arm64.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D src/ic/ia32/stub-cache-ia32.cc View 1 chunk +0 lines, -185 lines 0 comments Download
M src/ic/ic.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/ic-compiler.h View 1 chunk +0 lines, -7 lines 0 comments Download
D src/ic/mips/ic-compiler-mips.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D src/ic/mips/stub-cache-mips.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D src/ic/mips64/ic-compiler-mips64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D src/ic/mips64/stub-cache-mips64.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D src/ic/ppc/ic-compiler-ppc.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D src/ic/ppc/stub-cache-ppc.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D src/ic/s390/ic-compiler-s390.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 chunk +0 lines, -266 lines 0 comments Download
D src/ic/s390/stub-cache-s390.cc View 1 chunk +0 lines, -173 lines 0 comments Download
M src/ic/stub-cache.h View 1 chunk +0 lines, -7 lines 0 comments Download
D src/ic/x64/ic-compiler-x64.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D src/ic/x64/stub-cache-x64.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D src/ic/x87/ic-compiler-x87.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D src/ic/x87/stub-cache-x87.cc View 1 chunk +0 lines, -185 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -227 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +0 lines, -345 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 4 chunks +0 lines, -53 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +0 lines, -134 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -227 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 1 chunk +0 lines, -342 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 4 chunks +0 lines, -52 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 4 chunks +0 lines, -134 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -240 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 4 chunks +0 lines, -45 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 4 chunks +0 lines, -121 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -234 lines 0 comments Download
M src/s390/codegen-s390.cc View 1 chunk +0 lines, -300 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 4 chunks +0 lines, -45 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 4 chunks +0 lines, -124 lines 0 comments Download
M src/v8.gyp View 1 9 chunks +0 lines, -18 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -197 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +0 lines, -48 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +0 lines, -118 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -322 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +0 lines, -268 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 3 chunks +0 lines, -41 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +0 lines, -118 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jakob Kummerow
PTAL :-)
4 years, 1 month ago (2016-11-21 19:27:30 UTC) #2
Igor Sheludko
Awesome! Now the dummy vector can also go away. LGTM!
4 years, 1 month ago (2016-11-21 22:22:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523473002/20001
4 years, 1 month ago (2016-11-22 15:14:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 15:43:49 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 15:44:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ef05d8e2c4c46f6a0c65544a1857c4f08a23176
Cr-Commit-Position: refs/heads/master@{#41188}

Powered by Google App Engine
This is Rietveld 408576698