| Index: src/ic/arm64/ic-arm64.cc
|
| diff --git a/src/ic/arm64/ic-arm64.cc b/src/ic/arm64/ic-arm64.cc
|
| index 0ced207d8a5bdaa5eee1fc4b6333e37c3300f547..97007b346cf71ae70b02c87973a481c54f2069d5 100644
|
| --- a/src/ic/arm64/ic-arm64.cc
|
| +++ b/src/ic/arm64/ic-arm64.cc
|
| @@ -197,266 +197,6 @@ void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
|
| __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
|
| }
|
|
|
| -static void KeyedStoreGenerateMegamorphicHelper(
|
| - MacroAssembler* masm, Label* fast_object, Label* fast_double, Label* slow,
|
| - KeyedStoreCheckMap check_map, KeyedStoreIncrementLength increment_length,
|
| - Register value, Register key, Register receiver, Register receiver_map,
|
| - Register elements_map, Register elements) {
|
| - DCHECK(!AreAliased(value, key, receiver, receiver_map, elements_map, elements,
|
| - x10, x11));
|
| -
|
| - Label transition_smi_elements;
|
| - Label transition_double_elements;
|
| - Label fast_double_without_map_check;
|
| - Label non_double_value;
|
| - Label finish_store;
|
| -
|
| - __ Bind(fast_object);
|
| - if (check_map == kCheckMap) {
|
| - __ Ldr(elements_map, FieldMemOperand(elements, HeapObject::kMapOffset));
|
| - __ Cmp(elements_map,
|
| - Operand(masm->isolate()->factory()->fixed_array_map()));
|
| - __ B(ne, fast_double);
|
| - }
|
| -
|
| - // HOLECHECK: guards "A[i] = V"
|
| - // We have to go to the runtime if the current value is the hole because there
|
| - // may be a callback on the element.
|
| - Label holecheck_passed;
|
| - __ Add(x10, elements, FixedArray::kHeaderSize - kHeapObjectTag);
|
| - __ Add(x10, x10, Operand::UntagSmiAndScale(key, kPointerSizeLog2));
|
| - __ Ldr(x11, MemOperand(x10));
|
| - __ JumpIfNotRoot(x11, Heap::kTheHoleValueRootIndex, &holecheck_passed);
|
| - __ JumpIfDictionaryInPrototypeChain(receiver, elements_map, x10, slow);
|
| - __ bind(&holecheck_passed);
|
| -
|
| - // Smi stores don't require further checks.
|
| - __ JumpIfSmi(value, &finish_store);
|
| -
|
| - // Escape to elements kind transition case.
|
| - __ CheckFastObjectElements(receiver_map, x10, &transition_smi_elements);
|
| -
|
| - __ Bind(&finish_store);
|
| - if (increment_length == kIncrementLength) {
|
| - // Add 1 to receiver->length.
|
| - __ Add(x10, key, Smi::FromInt(1));
|
| - __ Str(x10, FieldMemOperand(receiver, JSArray::kLengthOffset));
|
| - }
|
| -
|
| - Register address = x11;
|
| - __ Add(address, elements, FixedArray::kHeaderSize - kHeapObjectTag);
|
| - __ Add(address, address, Operand::UntagSmiAndScale(key, kPointerSizeLog2));
|
| - __ Str(value, MemOperand(address));
|
| -
|
| - Label dont_record_write;
|
| - __ JumpIfSmi(value, &dont_record_write);
|
| -
|
| - // Update write barrier for the elements array address.
|
| - __ Mov(x10, value); // Preserve the value which is returned.
|
| - __ RecordWrite(elements, address, x10, kLRHasNotBeenSaved, kDontSaveFPRegs,
|
| - EMIT_REMEMBERED_SET, OMIT_SMI_CHECK);
|
| -
|
| - __ Bind(&dont_record_write);
|
| - __ Ret();
|
| -
|
| -
|
| - __ Bind(fast_double);
|
| - if (check_map == kCheckMap) {
|
| - // Check for fast double array case. If this fails, call through to the
|
| - // runtime.
|
| - __ JumpIfNotRoot(elements_map, Heap::kFixedDoubleArrayMapRootIndex, slow);
|
| - }
|
| -
|
| - // HOLECHECK: guards "A[i] double hole?"
|
| - // We have to see if the double version of the hole is present. If so go to
|
| - // the runtime.
|
| - __ Add(x10, elements, FixedDoubleArray::kHeaderSize - kHeapObjectTag);
|
| - __ Add(x10, x10, Operand::UntagSmiAndScale(key, kPointerSizeLog2));
|
| - __ Ldr(x11, MemOperand(x10));
|
| - __ CompareAndBranch(x11, kHoleNanInt64, ne, &fast_double_without_map_check);
|
| - __ JumpIfDictionaryInPrototypeChain(receiver, elements_map, x10, slow);
|
| -
|
| - __ Bind(&fast_double_without_map_check);
|
| - __ StoreNumberToDoubleElements(value, key, elements, x10, d0,
|
| - &transition_double_elements);
|
| - if (increment_length == kIncrementLength) {
|
| - // Add 1 to receiver->length.
|
| - __ Add(x10, key, Smi::FromInt(1));
|
| - __ Str(x10, FieldMemOperand(receiver, JSArray::kLengthOffset));
|
| - }
|
| - __ Ret();
|
| -
|
| -
|
| - __ Bind(&transition_smi_elements);
|
| - // Transition the array appropriately depending on the value type.
|
| - __ Ldr(x10, FieldMemOperand(value, HeapObject::kMapOffset));
|
| - __ JumpIfNotRoot(x10, Heap::kHeapNumberMapRootIndex, &non_double_value);
|
| -
|
| - // Value is a double. Transition FAST_SMI_ELEMENTS ->
|
| - // FAST_DOUBLE_ELEMENTS and complete the store.
|
| - __ LoadTransitionedArrayMapConditional(
|
| - FAST_SMI_ELEMENTS, FAST_DOUBLE_ELEMENTS, receiver_map, x10, x11, slow);
|
| - AllocationSiteMode mode =
|
| - AllocationSite::GetMode(FAST_SMI_ELEMENTS, FAST_DOUBLE_ELEMENTS);
|
| - ElementsTransitionGenerator::GenerateSmiToDouble(masm, receiver, key, value,
|
| - receiver_map, mode, slow);
|
| - __ Ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
|
| - __ B(&fast_double_without_map_check);
|
| -
|
| - __ Bind(&non_double_value);
|
| - // Value is not a double, FAST_SMI_ELEMENTS -> FAST_ELEMENTS.
|
| - __ LoadTransitionedArrayMapConditional(FAST_SMI_ELEMENTS, FAST_ELEMENTS,
|
| - receiver_map, x10, x11, slow);
|
| -
|
| - mode = AllocationSite::GetMode(FAST_SMI_ELEMENTS, FAST_ELEMENTS);
|
| - ElementsTransitionGenerator::GenerateMapChangeElementsTransition(
|
| - masm, receiver, key, value, receiver_map, mode, slow);
|
| -
|
| - __ Ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
|
| - __ B(&finish_store);
|
| -
|
| - __ Bind(&transition_double_elements);
|
| - // Elements are FAST_DOUBLE_ELEMENTS, but value is an Object that's not a
|
| - // HeapNumber. Make sure that the receiver is a Array with FAST_ELEMENTS and
|
| - // transition array from FAST_DOUBLE_ELEMENTS to FAST_ELEMENTS
|
| - __ LoadTransitionedArrayMapConditional(FAST_DOUBLE_ELEMENTS, FAST_ELEMENTS,
|
| - receiver_map, x10, x11, slow);
|
| - mode = AllocationSite::GetMode(FAST_DOUBLE_ELEMENTS, FAST_ELEMENTS);
|
| - ElementsTransitionGenerator::GenerateDoubleToObject(
|
| - masm, receiver, key, value, receiver_map, mode, slow);
|
| - __ Ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
|
| - __ B(&finish_store);
|
| -}
|
| -
|
| -
|
| -void KeyedStoreIC::GenerateMegamorphic(MacroAssembler* masm,
|
| - LanguageMode language_mode) {
|
| - ASM_LOCATION("KeyedStoreIC::GenerateMegamorphic");
|
| - Label slow;
|
| - Label array;
|
| - Label fast_object;
|
| - Label extra;
|
| - Label fast_object_grow;
|
| - Label fast_double_grow;
|
| - Label fast_double;
|
| - Label maybe_name_key;
|
| - Label miss;
|
| -
|
| - Register value = StoreDescriptor::ValueRegister();
|
| - Register key = StoreDescriptor::NameRegister();
|
| - Register receiver = StoreDescriptor::ReceiverRegister();
|
| - DCHECK(receiver.is(x1));
|
| - DCHECK(key.is(x2));
|
| - DCHECK(value.is(x0));
|
| -
|
| - Register receiver_map = x3;
|
| - Register elements = x4;
|
| - Register elements_map = x5;
|
| -
|
| - __ JumpIfNotSmi(key, &maybe_name_key);
|
| - __ JumpIfSmi(receiver, &slow);
|
| - __ Ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset));
|
| -
|
| - // Check that the receiver does not require access checks.
|
| - // The generic stub does not perform map checks.
|
| - __ Ldrb(x10, FieldMemOperand(receiver_map, Map::kBitFieldOffset));
|
| - __ TestAndBranchIfAnySet(x10, (1 << Map::kIsAccessCheckNeeded), &slow);
|
| -
|
| - // Check if the object is a JS array or not.
|
| - Register instance_type = x10;
|
| - __ CompareInstanceType(receiver_map, instance_type, JS_ARRAY_TYPE);
|
| - __ B(eq, &array);
|
| - // Check that the object is some kind of JS object EXCEPT JS Value type. In
|
| - // the case that the object is a value-wrapper object, we enter the runtime
|
| - // system to make sure that indexing into string objects works as intended.
|
| - STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE);
|
| - __ Cmp(instance_type, JS_OBJECT_TYPE);
|
| - __ B(lo, &slow);
|
| -
|
| - // Object case: Check key against length in the elements array.
|
| - __ Ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
|
| - // Check array bounds. Both the key and the length of FixedArray are smis.
|
| - __ Ldrsw(x10, UntagSmiFieldMemOperand(elements, FixedArray::kLengthOffset));
|
| - __ Cmp(x10, Operand::UntagSmi(key));
|
| - __ B(hi, &fast_object);
|
| -
|
| -
|
| - __ Bind(&slow);
|
| - // Slow case, handle jump to runtime.
|
| - // Live values:
|
| - // x0: value
|
| - // x1: key
|
| - // x2: receiver
|
| - PropertyICCompiler::GenerateRuntimeSetProperty(masm, language_mode);
|
| - // Never returns to here.
|
| -
|
| - __ bind(&maybe_name_key);
|
| - __ Ldr(x10, FieldMemOperand(key, HeapObject::kMapOffset));
|
| - __ Ldrb(x10, FieldMemOperand(x10, Map::kInstanceTypeOffset));
|
| - __ JumpIfNotUniqueNameInstanceType(x10, &slow);
|
| -
|
| - // The handlers in the stub cache expect a vector and slot. Since we won't
|
| - // change the IC from any downstream misses, a dummy vector can be used.
|
| - Register vector = StoreWithVectorDescriptor::VectorRegister();
|
| - Register slot = StoreWithVectorDescriptor::SlotRegister();
|
| - DCHECK(!AreAliased(vector, slot, x5, x6, x7, x8));
|
| - Handle<TypeFeedbackVector> dummy_vector =
|
| - TypeFeedbackVector::DummyVector(masm->isolate());
|
| - int slot_index = dummy_vector->GetIndex(
|
| - FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
|
| - __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
|
| - __ Mov(slot, Operand(Smi::FromInt(slot_index)));
|
| -
|
| - masm->isolate()->store_stub_cache()->GenerateProbe(masm, receiver, key, x5,
|
| - x6, x7, x8);
|
| - // Cache miss.
|
| - __ B(&miss);
|
| -
|
| - __ Bind(&extra);
|
| - // Extra capacity case: Check if there is extra capacity to
|
| - // perform the store and update the length. Used for adding one
|
| - // element to the array by writing to array[array.length].
|
| -
|
| - // Check for room in the elements backing store.
|
| - // Both the key and the length of FixedArray are smis.
|
| - __ Ldrsw(x10, UntagSmiFieldMemOperand(elements, FixedArray::kLengthOffset));
|
| - __ Cmp(x10, Operand::UntagSmi(key));
|
| - __ B(ls, &slow);
|
| -
|
| - __ Ldr(elements_map, FieldMemOperand(elements, HeapObject::kMapOffset));
|
| - __ Cmp(elements_map, Operand(masm->isolate()->factory()->fixed_array_map()));
|
| - __ B(eq, &fast_object_grow);
|
| - __ Cmp(elements_map,
|
| - Operand(masm->isolate()->factory()->fixed_double_array_map()));
|
| - __ B(eq, &fast_double_grow);
|
| - __ B(&slow);
|
| -
|
| -
|
| - __ Bind(&array);
|
| - // Array case: Get the length and the elements array from the JS
|
| - // array. Check that the array is in fast mode (and writable); if it
|
| - // is the length is always a smi.
|
| -
|
| - __ Ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
|
| -
|
| - // Check the key against the length in the array.
|
| - __ Ldrsw(x10, UntagSmiFieldMemOperand(receiver, JSArray::kLengthOffset));
|
| - __ Cmp(x10, Operand::UntagSmi(key));
|
| - __ B(eq, &extra); // We can handle the case where we are appending 1 element.
|
| - __ B(lo, &slow);
|
| -
|
| - KeyedStoreGenerateMegamorphicHelper(
|
| - masm, &fast_object, &fast_double, &slow, kCheckMap, kDontIncrementLength,
|
| - value, key, receiver, receiver_map, elements_map, elements);
|
| - KeyedStoreGenerateMegamorphicHelper(masm, &fast_object_grow,
|
| - &fast_double_grow, &slow, kDontCheckMap,
|
| - kIncrementLength, value, key, receiver,
|
| - receiver_map, elements_map, elements);
|
| -
|
| - __ bind(&miss);
|
| - GenerateMiss(masm);
|
| -}
|
| -
|
| void StoreIC::GenerateMiss(MacroAssembler* masm) {
|
| StoreIC_PushArgs(masm);
|
|
|
|
|