Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/code-stubs.h

Issue 2523473002: [cleanup] Drop handwritten KeyedStoreIC code (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/codegen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 588a3069afa60ac9a55e7dafa35d13393e94a533..3dcc468c6972ebe08834426ed840adeb931f5cd4 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -44,7 +44,6 @@ class ObjectLiteral;
V(StoreBufferOverflow) \
V(StoreElement) \
V(SubString) \
- V(KeyedStoreIC) \
V(LoadGlobalIC) \
V(FastNewObject) \
V(FastNewRestParameter) \
@@ -59,7 +58,6 @@ class ObjectLiteral;
/* version of the corresponding stub is */ \
/* used universally */ \
V(CallICTrampoline) \
- V(KeyedStoreICTrampoline) \
/* --- HydrogenCodeStubs --- */ \
/* These builtins w/ JS linkage are */ \
/* just fast-cases of C++ builtins. They */ \
@@ -1999,27 +1997,6 @@ class StoreICTrampolineStub : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(StoreICTrampoline, TurboFanCodeStub);
};
-class KeyedStoreICTrampolineStub : public PlatformCodeStub {
- public:
- KeyedStoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
- : PlatformCodeStub(isolate) {
- minor_key_ = state.GetExtraICState();
- }
-
- Code::Kind GetCodeKind() const override { return Code::KEYED_STORE_IC; }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- protected:
- StoreICState state() const { return StoreICState(GetExtraICState()); }
-
- private:
- DEFINE_CALL_INTERFACE_DESCRIPTOR(Store);
- DEFINE_PLATFORM_CODE_STUB(KeyedStoreICTrampoline, PlatformCodeStub);
-};
-
class KeyedStoreICTrampolineTFStub : public StoreICTrampolineStub {
public:
KeyedStoreICTrampolineTFStub(Isolate* isolate, const StoreICState& state)
@@ -2142,28 +2119,6 @@ class StoreICStub : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(StoreIC, TurboFanCodeStub);
};
-class KeyedStoreICStub : public PlatformCodeStub {
- public:
- KeyedStoreICStub(Isolate* isolate, const StoreICState& state)
- : PlatformCodeStub(isolate) {
- minor_key_ = state.GetExtraICState();
- }
-
- void GenerateForTrampoline(MacroAssembler* masm);
-
- Code::Kind GetCodeKind() const final { return Code::KEYED_STORE_IC; }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(StoreWithVector);
- DEFINE_PLATFORM_CODE_STUB(KeyedStoreIC, PlatformCodeStub);
-
- protected:
- void GenerateImpl(MacroAssembler* masm, bool in_frame);
-};
-
class KeyedStoreICTFStub : public StoreICStub {
public:
KeyedStoreICTFStub(Isolate* isolate, const StoreICState& state)
« no previous file with comments | « src/code-factory.cc ('k') | src/codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698