Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523233002:
[css-grid] Implied minimum size only applies if overflow is visible (Closed)
|
Created:
4 years ago by Manuel Rego Modified:
4 years ago CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[css-grid] Implied minimum size only applies if overflow is visible
Before this was manged in LayoutBox, but since we removed that code in
https://codereview.chromium.org/2398043002, we were not longer verifying
if overflow is or not visible.
BUG=667057
TEST=fast/css-grid-layout/grid-item-overflow.html
Committed: https://crrev.com/0670a81ba8de8f6c7dbb4c34a613a5e1f1777a8d
Cr-Commit-Position: refs/heads/master@{#434381}
Patch Set 1 #
Total comments: 8
Patch Set 2 : Apply suggested changes #Patch Set 3 : Apply suggested changes #
Messages
Total messages: 27 (12 generated)
rego@igalia.com changed reviewers: + cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com
https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html (right): https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html:4: display: inline-grid; Why inline-grid ? https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html:17: .auto { we can save some lines if we define these rules in 1 line. https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html:21: .hidden { ditto. https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1248: if (!childSize.isAuto() || (childMinSize.isAuto() && overflowIsVisible)) why overflow visibility only applied if childMinSize is auto ?
Thanks for the quick review. Uploaded new version. https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html (right): https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html:4: display: inline-grid; On 2016/11/23 15:59:30, jfernandez wrote: > Why inline-grid ? Why not? :-) Basically it's because it fits better on the viewport. I could tweak font sizes and margins if you prefer to use "grid". https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html:17: .auto { On 2016/11/23 15:59:30, jfernandez wrote: > we can save some lines if we define these rules in 1 line. Done. https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html:21: .hidden { On 2016/11/23 15:59:30, jfernandez wrote: > ditto. Done. https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/2523233002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1248: if (!childSize.isAuto() || (childMinSize.isAuto() && overflowIsVisible)) On 2016/11/23 15:59:30, jfernandez wrote: > why overflow visibility only applied if childMinSize is auto ? It's what we're precisely fixing here, check the text on the spec (https://drafts.csswg.org/css-grid/#min-size-auto): "applies an automatic minimum size in the specified axis to grid items whose 'overflow' is 'visible'."
lgtm
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480008962162310,
"parent_rev": "73b3478f2ee436c605ba26905cd5f810a236c1c5", "commit_rev":
"f5bb6769108eb79a8a35e1b8e6cb5f71ed9baf65"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [css-grid] Implied minimum size only applies if overflow is visible Before this was manged in LayoutBox, but since we removed that code in https://codereview.chromium.org/2398043002, we were not longer verifying if overflow is or not visible. BUG=667057 TEST=fast/css-grid-layout/grid-item-overflow.html ========== to ========== [css-grid] Implied minimum size only applies if overflow is visible Before this was manged in LayoutBox, but since we removed that code in https://codereview.chromium.org/2398043002, we were not longer verifying if overflow is or not visible. BUG=667057 TEST=fast/css-grid-layout/grid-item-overflow.html Committed: https://crrev.com/0670a81ba8de8f6c7dbb4c34a613a5e1f1777a8d Cr-Commit-Position: refs/heads/master@{#434381} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0670a81ba8de8f6c7dbb4c34a613a5e1f1777a8d Cr-Commit-Position: refs/heads/master@{#434381} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
