third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html - Issue 2523233002: [css-grid] Implied minimum size only applies if overflow is visible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html

Issue 2523233002: [css-grid] Implied minimum size only applies if overflow is visible (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .grid {

	4 display: inline-grid;
	jfernandez 2016/11/23 15:59:30 Why inline-grid ? Why inline-grid ? Manuel Rego 2016/11/23 16:24:35 Why not? :-) Basically it's because it fits bette Show quoted text On 2016/11/23 15:59:30, jfernandez wrote: > Why inline-grid ? Why not? :-) Basically it's because it fits better on the viewport. I could tweak font sizes and margins if you prefer to use "grid".
	5 border: thick solid;

	6 height: 50px;

	7 width: 50px;

	8 margin: 50px;

	9 }

	10

	11 .i1 {

	12 color: cyan;

	13 background: magenta;

	14 font-size: 100px;

	15 }

	16

	17 .auto {
	jfernandez 2016/11/23 15:59:30 we can save some lines if we define these rules in we can save some lines if we define these rules in 1 line. Manuel Rego 2016/11/23 16:24:36 Done. Show quoted text On 2016/11/23 15:59:30, jfernandez wrote: > we can save some lines if we define these rules in 1 line. Done.
	18 overflow: auto;

	19 }

	20

	21 .hidden {
	jfernandez 2016/11/23 15:59:30 ditto. ditto. Manuel Rego 2016/11/23 16:24:35 Done. Show quoted text On 2016/11/23 15:59:30, jfernandez wrote: > ditto. Done.
	22 overflow: hidden;

	23 }

	24 </style>

	25

	26 <p>This test checks that implied minimum size of grid items is only applied if o verflow is visible.</p>

	27 <p>The test passes if in the first grid the item overflows, in the second one it has scrollbars, and in the third one the item doesn't overflow but it doesn't h ave scrollbars.</p>

	28

	29 <div class="grid">

	30 <div class="i1">X</div>

	31 </div>

	32

	33 <div class="grid">

	34 <div class="i1 auto">X</div>

	35 </div>

	36

	37 <div class="grid">

	38 <div class="i1 hidden">X</div>

	39 </div>

OLD	NEW