Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(2)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html
Issue
2523233002
:
[css-grid] Implied minimum size only applies if overflow is visible (Closed)
Patch Set: Apply suggested changes
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow.html
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-expected.html
third_party/WebKit/Source/core/layout/LayoutGrid.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-expected.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
.grid {
4
display: inline-grid;
5
border: thick solid;
6
height: 50px;
7
width: 50px;
8
margin: 50px;
9
}
10
11
.i1 {
12
color: cyan;
13
background: magenta;
14
font-size: 100px;
15
}
16
17
.auto { overflow: auto; }
18
.hidden { overflow: hidden; }
19
</style>
20
21
<p>This test checks that implied minimum size of grid items is only applied if o verflow is visible.</p>
22
<p>The test passes if in the first grid the item overflows, in the second one it has scrollbars,
23
and in the third one the item doesn't overflow but it doesn't have scrollbars.</ p>
24
25
<div class="grid">
26
<div class="i1">X</div>
27
</div>
28
29
<div class="grid">
30
<div class="i1 auto">X</div>
31
</div>
32
33
<div class="grid">
34
<div class="i1 hidden">X</div>
35
</div>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-expected.html »
('j') |
no next file with comments »
Issue 2523233002: [css-grid] Implied minimum size only applies if overflow is visible (Closed)
Created 4 years ago by Manuel Rego
Modified 4 years ago
Reviewers: svillar, jfernandez, cbiesinger
Base URL:
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 2523233002:
[css-grid] Implied minimum size only applies if overflow is visible (Closed)
