Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2523233002: [css-grid] Implied minimum size only applies if overflow is visible (Closed)
Patch Set: Apply suggested changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 361720fa2aa0271a698e9a718821f2587cf8346f..aceda264c09ee0bc15c02adb5c0f9a535bda5ba5 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -1242,7 +1242,10 @@ LayoutUnit LayoutGrid::minSizeForChild(LayoutBox& child,
: child.styleRef().logicalHeight();
const Length& childMinSize = isRowAxis ? child.styleRef().logicalMinWidth()
: child.styleRef().logicalMinHeight();
- if (!childSize.isAuto() || childMinSize.isAuto())
+ bool overflowIsVisible =
+ isRowAxis ? child.styleRef().overflowInlineDirection() == OverflowVisible
+ : child.styleRef().overflowBlockDirection() == OverflowVisible;
+ if (!childSize.isAuto() || (childMinSize.isAuto() && overflowIsVisible))
return minContentForChild(child, direction, sizingData);
bool overrideSizeHasChanged =
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698