TestBrowserThreads must outlive TestProfiles and TestProfileManagers

TestBrowserThreads must outlive TestProfiles and TestProfileManagers

Otherwise they trigger an unhappy DCHECK that verifies that profiles
are destroyed on the UI thread.

This is a pre-requirement for https://codereview.chromium.org/2464233002
which will reset global BrowserThread state in ~BrowserThreadImpl()

The incorrect destruction order previously "worked" because BrowserThread
globals weren't cleaned up in between tests...

BUG=653916
Committed: https://crrev.com/57d179c25000b2764d97096a7bfa910e9ffba89a
Cr-Commit-Position: refs/heads/master@{#434061}

[gab, 2016-11-22 22:47:39]

gab@chromium.org changed reviewers:
+ sky@chromium.org

[gab, 2016-11-22 22:47:40]

@sky PTAL, thanks

[gab, 2016-11-22 22:47:49]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:48:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:33:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:33:22]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-22 23:34:50]

LGTM

[gab, 2016-11-22 23:45:21]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:46:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 01:13:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479858321491980, "parent_rev":
"1558359eed5a67c8f3ceced4fc1ead4c5e614931", "commit_rev":
"c59a068a9ca44e89f9d78c4439afb10b187e53ec"}

[commit-bot: I haz the power, 2016-11-23 01:13:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-23 01:17:34]

Description was changed from

==========
TestBrowserThreads must outlive TestProfiles and TestProfileManagers

Otherwise they trigger an unhappy DCHECK that verifies that profiles
are destroyed on the UI thread.

This is a pre-requirement for https://codereview.chromium.org/2464233002
which will reset global BrowserThread state in ~BrowserThreadImpl()

The incorrect destruction order previously "worked" because BrowserThread
globals weren't cleaned up in between tests...

BUG=653916
==========

to

==========
TestBrowserThreads must outlive TestProfiles and TestProfileManagers

Otherwise they trigger an unhappy DCHECK that verifies that profiles
are destroyed on the UI thread.

This is a pre-requirement for https://codereview.chromium.org/2464233002
which will reset global BrowserThread state in ~BrowserThreadImpl()

The incorrect destruction order previously "worked" because BrowserThread
globals weren't cleaned up in between tests...

BUG=653916

Committed: https://crrev.com/57d179c25000b2764d97096a7bfa910e9ffba89a
Cr-Commit-Position: refs/heads/master@{#434061}
==========

[commit-bot: I haz the power, 2016-11-23 01:17:35]

Patchset 1 (id:??) landed as
https://crrev.com/57d179c25000b2764d97096a7bfa910e9ffba89a
Cr-Commit-Position: refs/heads/master@{#434061}