Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/sessions/session_restore_stats_collector_unittest.cc

Issue 2523093002: TestBrowserThreads must outlive TestProfiles and TestProfileManagers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_restore_stats_collector_unittest.cc
diff --git a/chrome/browser/sessions/session_restore_stats_collector_unittest.cc b/chrome/browser/sessions/session_restore_stats_collector_unittest.cc
index 26e25db2146de30fdcf492d33251f7727bda95e5..7e6e90e63c043e31a656394c83d0b799d5233736 100644
--- a/chrome/browser/sessions/session_restore_stats_collector_unittest.cc
+++ b/chrome/browser/sessions/session_restore_stats_collector_unittest.cc
@@ -296,8 +296,9 @@ class SessionRestoreStatsCollectorTest : public testing::Test {
// Infrastructure needed for using the TestWebContentsFactory. These are
// initialized once by the fixture and reused across unittests.
base::MessageLoop message_loop_;
- TestingProfile testing_profile_;
content::TestBrowserThread ui_thread_;
+ // |ui_thread_| needs to still be alive when |testing_profile_| is destroyed.
+ TestingProfile testing_profile_;
// A new web contents factory is generated per test. This automatically cleans
// up any tabs created by previous tests.
« no previous file with comments | « chrome/browser/profiles/profile_statistics_unittest.cc ('k') | chrome/browser/sessions/tab_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698