Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: chrome/browser/profiles/profile_info_cache_unittest.h

Issue 2523093002: TestBrowserThreads must outlive TestProfiles and TestProfileManagers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_info_cache_unittest.h
diff --git a/chrome/browser/profiles/profile_info_cache_unittest.h b/chrome/browser/profiles/profile_info_cache_unittest.h
index c052e4bac387978320a8b5ed242740578a02c578..c783e619e533418fc807b485df45cb5a2591e681 100644
--- a/chrome/browser/profiles/profile_info_cache_unittest.h
+++ b/chrome/browser/profiles/profile_info_cache_unittest.h
@@ -56,11 +56,15 @@ class ProfileInfoCacheTest : public testing::Test {
base::FilePath GetProfilePath(const std::string& base_name);
void ResetCache();
+ private:
+ // TestBrowserThreadBundle needs to be up through the destruction of the
+ // TestingProfileManager below.
+ content::TestBrowserThreadBundle thread_bundle_;
+
protected:
TestingProfileManager testing_profile_manager_;
private:
- content::TestBrowserThreadBundle thread_bundle_;
ProfileNameVerifierObserver name_observer_;
base::ScopedPathOverride user_data_dir_override_;
};
« no previous file with comments | « chrome/browser/prerender/prerender_unittest.cc ('k') | chrome/browser/profiles/profile_list_desktop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698