Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7673)

Unified Diff: chrome/browser/sessions/tab_loader_unittest.cc

Issue 2523093002: TestBrowserThreads must outlive TestProfiles and TestProfileManagers (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/tab_loader_unittest.cc
diff --git a/chrome/browser/sessions/tab_loader_unittest.cc b/chrome/browser/sessions/tab_loader_unittest.cc
index 313456479ba7ee1504a17fd1c31e92c2e0f6cf2c..3f7aae7be0eabfa0b9cd975a80e40604e5265506 100644
--- a/chrome/browser/sessions/tab_loader_unittest.cc
+++ b/chrome/browser/sessions/tab_loader_unittest.cc
@@ -14,7 +14,7 @@
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_features.h"
#include "content/public/test/memory_coordinator_test_utils.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_web_contents_factory.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -22,8 +22,7 @@ class TabLoaderTest : public testing::Test {
public:
using RestoredTab = SessionRestoreDelegate::RestoredTab;
- TabLoaderTest()
- : ui_thread_(content::BrowserThread::UI, &message_loop_) {}
+ TabLoaderTest() = default;
// testing::Test:
void SetUp() override {
@@ -45,9 +44,8 @@ class TabLoaderTest : public testing::Test {
std::unique_ptr<content::TestWebContentsFactory> test_web_contents_factory_;
std::vector<RestoredTab> restored_tabs_;
- base::MessageLoop message_loop_;
+ content::TestBrowserThreadBundle thread_bundle_;
TestingProfile testing_profile_;
- content::TestBrowserThread ui_thread_;
base::test::ScopedFeatureList scoped_feature_list_;
private:

Powered by Google App Engine
This is Rietveld 408576698