Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
TBR=oshima@chromium.org

Committed: https://crrev.com/2dfeded24ecab161d83c6d104c9304efb271c851
Cr-Commit-Position: refs/heads/master@{#434199}

[kozy, 2016-11-21 17:47:14]

Dmitry, please take a look on inspector_protocol.
I'll roll inspector_protocol in V8 first to introduce new
v8_inspector::V8Inspector::Channel (will upload CL soon) there and then roll all
together in blink.

[dgozman, 2016-11-21 22:29:16]

https://codereview.chromium.org/2522583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorSession.cpp (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorSession.cpp:137: return
m_notification->serializeValue()->toJSONString();
Let's clear m_notification here to not store extra data?

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/CodeGenerator.py (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/CodeGenerator.py:340: for type in domain["types"]
if "types" in domain else []:
Advanced python right here!

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:140: class
SerializableResponse : public Serializable {
Can we combine this with Notification class?

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/lib/FrontendChannel_h.template (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/lib/FrontendChannel_h.template:14: virtual
std::unique_ptr<protocol::Value> serializeValue() const = 0;
8 spaces?

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/lib/FrontendChannel_h.template:14: virtual
std::unique_ptr<protocol::Value> serializeValue() const = 0;
Why return value and not json string?
I'd call this toJSONString actually, and make values implement the interface.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:150: class
Notification : public Serializable {
This should not be in template - it will be generated multiple times.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:163: params =
DictionaryValue::create();
4 spaces

[kozy, 2016-11-22 01:25:38]

all done, please take a look!

https://codereview.chromium.org/2522583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorSession.cpp (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorSession.cpp:137: return
m_notification->serializeValue()->toJSONString();
On 2016/11/21 22:29:16, dgozman wrote:
> Let's clear m_notification here to not store extra data?

Done.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:140: class
SerializableResponse : public Serializable {
On 2016/11/21 22:29:16, dgozman wrote:
> Can we combine this with Notification class?

Done.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/lib/FrontendChannel_h.template (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/lib/FrontendChannel_h.template:14: virtual
std::unique_ptr<protocol::Value> serializeValue() const = 0;
On 2016/11/21 22:29:16, dgozman wrote:
> Why return value and not json string?
> I'd call this toJSONString actually, and make values implement the interface.

Done.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/lib/FrontendChannel_h.template:14: virtual
std::unique_ptr<protocol::Value> serializeValue() const = 0;
On 2016/11/21 22:29:16, dgozman wrote:
> 8 spaces?

Done.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:150: class
Notification : public Serializable {
On 2016/11/21 22:29:16, dgozman wrote:
> This should not be in template - it will be generated multiple times.

Done.

https://codereview.chromium.org/2522583002/diff/20001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:163: params =
DictionaryValue::create();
On 2016/11/21 22:29:16, dgozman wrote:
> 4 spaces

Done.

[kozy, 2016-11-22 18:44:09]

FYI: v8 roll: https://codereview.chromium.org/2523583005/

[dgozman, 2016-11-22 19:39:24]

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/CodeGenerator.py (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/CodeGenerator.py:510: for event in
domain["events"]:
Let's do this before create_type_definitions, and it should just work.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/lib/Array_h.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/Array_h.template:60:
std::unique_ptr<protocol::ListValue> serializeValue()
Let's go for consistent naming:
- serialize which returns string;
- parse which parses string;
- toValue which returns value;
- fromValue which parses value.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:160:
fprintf(stderr, "callId: %d\n", callId);
fprintf!

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:194: void
setCallId(int callId)
Inline this.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:199: void
setData(const String& data) { m_data = data; }
Inline this.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:326: return
result->toJSONString();
m_params.reset()

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:332: ,
m_params(params ? std::move(params) : DictionaryValue::create())
Let's make it nullable.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/lib/DispatcherBase_h.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_h.template:134: String
serialize();
override

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_h.template:137:
InternalResponse(int callId, const String& type, std::unique_ptr<Serializable>
params);
Also need
~InternalResponse() override {}

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_h.template:140: String m_type;
m_notification

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:189: class
RawNotification : public Serializable {
Move this out of template as well.

[kozy, 2016-11-22 21:01:27]

all done, Dmitry, please take another look

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/CodeGenerator.py (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/CodeGenerator.py:510: for event in
domain["events"]:
On 2016/11/22 19:39:24, dgozman wrote:
> Let's do this before create_type_definitions, and it should just work.

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/lib/Array_h.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/Array_h.template:60:
std::unique_ptr<protocol::ListValue> serializeValue()
On 2016/11/22 19:39:24, dgozman wrote:
> Let's go for consistent naming:
> - serialize which returns string;
> - parse which parses string;
> - toValue which returns value;
> - fromValue which parses value.

serialize - done.
toValue/fromValue - done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:160:
fprintf(stderr, "callId: %d\n", callId);
On 2016/11/22 19:39:24, dgozman wrote:
> fprintf!

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:194: void
setCallId(int callId)
On 2016/11/22 19:39:24, dgozman wrote:
> Inline this.

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:199: void
setData(const String& data) { m_data = data; }
On 2016/11/22 19:39:24, dgozman wrote:
> Inline this.

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:326: return
result->toJSONString();
On 2016/11/22 19:39:24, dgozman wrote:
> m_params.reset()

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:332: ,
m_params(params ? std::move(params) : DictionaryValue::create())
On 2016/11/22 19:39:24, dgozman wrote:
> Let's make it nullable.

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/lib/DispatcherBase_h.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_h.template:134: String
serialize();
On 2016/11/22 19:39:24, dgozman wrote:
> override

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_h.template:137:
InternalResponse(int callId, const String& type, std::unique_ptr<Serializable>
params);
On 2016/11/22 19:39:24, dgozman wrote:
> Also need
> ~InternalResponse() override {}

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/lib/DispatcherBase_h.template:140: String m_type;
On 2016/11/22 19:39:24, dgozman wrote:
> m_notification

Done.

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/40001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:189: class
RawNotification : public Serializable {
On 2016/11/22 19:39:24, dgozman wrote:
> Move this out of template as well.

Done.

[dgozman, 2016-11-22 22:36:00]

lgtm

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
File third_party/inspector_protocol/lib/Values_h.template (right):

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/lib/Values_h.template:23: virtual ~Value() { }
override

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/lib/Values_h.template:51: String toJSONString()
const;
Remove this one now.

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
File third_party/inspector_protocol/templates/Imported_h.template (right):

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/templates/Imported_h.template:38: static
std::unique_ptr<protocol::Value> serialize(const
{{"::".join(config.imported.namespace)}}::{{domain.domain}}::API::{{type.id}}*
value)
toValue

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:17: class
RawNotification : public Serializable {
Move this to DispatcherBase.h

[kozy, 2016-11-22 23:01:25]

all done, thanks!

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
File third_party/inspector_protocol/lib/Values_h.template (right):

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/lib/Values_h.template:23: virtual ~Value() { }
On 2016/11/22 22:36:00, dgozman wrote:
> override

Done.

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/lib/Values_h.template:51: String toJSONString()
const;
On 2016/11/22 22:36:00, dgozman wrote:
> Remove this one now.

Done.

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
File third_party/inspector_protocol/templates/Imported_h.template (right):

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/templates/Imported_h.template:38: static
std::unique_ptr<protocol::Value> serialize(const
{{"::".join(config.imported.namespace)}}::{{domain.domain}}::API::{{type.id}}*
value)
On 2016/11/22 22:36:00, dgozman wrote:
> toValue

Done.

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
File third_party/inspector_protocol/templates/TypeBuilder_cpp.template (right):

https://codereview.chromium.org/2522583002/diff/80001/third_party/inspector_p...
third_party/inspector_protocol/templates/TypeBuilder_cpp.template:17: class
RawNotification : public Serializable {
On 2016/11/22 22:36:00, dgozman wrote:
> Move this to DispatcherBase.h

Done.

[kozy, 2016-11-23 01:18:09]

Description was changed from

==========
[DevTools] inspector_protocol reports serializable

sendProtocolResponse and sendProtocolNotification methods report serializable
object instead of serialized string. It allows client to serialize object when
client really needs it.

BUG=chromium:350797
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]

[1] https://codereview.chromium.org/2526603002

BUG=chromium:350797
R=dgozman@chromium.org
==========

[kozy, 2016-11-23 01:19:24]

Dmitry, please take a look!

V8 part is landed.

[dgozman, 2016-11-23 01:33:44]

This roll includes two commits actually. Please update the description.

lgtm

[kozy, 2016-11-23 15:57:58]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 15:58:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-11-23 16:48:15]

Description was changed from

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]

[1] https://codereview.chromium.org/2526603002

BUG=chromium:350797
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
==========

[kozy, 2016-11-23 16:49:15]

Description was changed from

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
TBR=oshima@chromium.org
==========

[kozy, 2016-11-23 17:02:01]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-23 17:02:02]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-11-23 17:02:33]

kozyatinskiy@chromium.org changed reviewers:
+ oshima@chromium.org

[kozy, 2016-11-23 17:33:14]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:33:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:40:01]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1479922394691590,
"parent_rev": "e0ce6ccc05a0cc09214d2d7ad34b0a48ed73acc6", "commit_rev":
"0c6a1c50e277f29983129fba13b2089554d144fd"}

[commit-bot: I haz the power, 2016-11-23 17:40:32]

Description was changed from

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
TBR=oshima@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
TBR=oshima@chromium.org
==========

[commit-bot: I haz the power, 2016-11-23 17:40:33]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-23 17:43:32]

Description was changed from

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
TBR=oshima@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

This roll includes:
  - [inspector_protocol] Introduce protocol::Serializable [1]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [2]

[1] https://codereview.chromium.org/2526603002
[2] https://codereview.chromium.org/2515343005

BUG=chromium:350797
R=dgozman@chromium.org
TBR=oshima@chromium.org

Committed: https://crrev.com/2dfeded24ecab161d83c6d104c9304efb271c851
Cr-Commit-Position: refs/heads/master@{#434199}
==========

[commit-bot: I haz the power, 2016-11-23 17:43:34]

Patchset 7 (id:??) landed as
https://crrev.com/2dfeded24ecab161d83c6d104c9304efb271c851
Cr-Commit-Position: refs/heads/master@{#434199}