third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)

Patch Set: updated README.chromium Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/tracing_handler.cc ('k') | third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index ca825b2a4d750403bbe534736a38a797efc11ed3..437b7d831c336f6445c8d40206677beafe98abd1 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -607,7 +607,7 @@ void InspectorDOMDebuggerAgent::breakProgramOnDOMEvent(Node* target,

ASSERT(breakpointOwnerNodeId);

description->setInteger("nodeId", breakpointOwnerNodeId);

description->setString("type", domTypeName(breakpointType));

- String json = description->toJSONString();

+ String json = description->serialize();

m_v8Session->breakProgram(

toV8InspectorStringView(

v8_inspector::protocol::Debugger::API::Paused::ReasonEnum::DOM),

@@ -647,7 +647,7 @@ void InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded(

bool synchronous) {

if (!eventData)

return;

- String json = eventData->toJSONString();

+ String json = eventData->serialize();

if (synchronous)

m_v8Session->breakProgram(

toV8InspectorStringView(v8_inspector::protocol::Debugger::API::Paused::

@@ -767,7 +767,7 @@ void InspectorDOMDebuggerAgent::willSendXMLHttpOrFetchNetworkRequest(

protocol::DictionaryValue::create();

eventData->setString("breakpointURL", breakpointURL);

eventData->setString("url", url);

- String json = eventData->toJSONString();

+ String json = eventData->serialize();

m_v8Session->breakProgram(

toV8InspectorStringView(

v8_inspector::protocol::Debugger::API::Paused::ReasonEnum::XHR),