Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2526603002: [inspector_protocol] Introduce protocol::Serializable (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] Introduce protocol::Serializable sendProtoolResponse and sendProtocolNotification methods report message as protocol::Serializable. So client can decide by itself when it's good time to setialize messages. BUG=chromium:350797 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol0c231497bdd29a2c17e04d6e7f4eb1030998a308 Committed: https://chromium.googlesource.com/deps/inspector_protocol4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

Patch Set 1 #

Patch Set 2 : addressed comments from https://codereview.chromium.org/2522583002/ #

Patch Set 3 : minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -110 lines) Patch
M CodeGenerator.py View 2 chunks +15 lines, -0 lines 0 comments Download
M lib/Array_h.template View 1 6 chunks +8 lines, -8 lines 0 comments Download
M lib/DispatcherBase_cpp.template View 1 3 chunks +91 lines, -25 lines 0 comments Download
M lib/DispatcherBase_h.template View 1 1 chunk +40 lines, -0 lines 0 comments Download
M lib/FrontendChannel_h.template View 1 chunk +8 lines, -2 lines 0 comments Download
M lib/Maybe_h.template View 1 chunk +1 line, -1 line 0 comments Download
M lib/Object_cpp.template View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/Object_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/ValueConversions_h.template View 1 14 chunks +23 lines, -23 lines 0 comments Download
M lib/Values_cpp.template View 1 2 chunks +8 lines, -8 lines 0 comments Download
M lib/Values_h.template View 1 2 chunks +3 lines, -3 lines 0 comments Download
M templates/Imported_h.template View 1 1 chunk +5 lines, -5 lines 0 comments Download
M templates/TypeBuilder_cpp.template View 1 2 10 chunks +33 lines, -27 lines 0 comments Download
M templates/TypeBuilder_h.template View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kozy
Dmitry, please take a look
4 years ago (2016-11-22 23:05:47 UTC) #1
dgozman
rs lgtm
4 years ago (2016-11-22 23:06:25 UTC) #2
kozy
Committed patchset #2 (id:20001) manually as 0c231497bdd29a2c17e04d6e7f4eb1030998a308 (presubmit successful).
4 years ago (2016-11-22 23:09:46 UTC) #4
kozy
4 years ago (2016-11-22 23:50:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698