Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.h

Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)
Patch Set: updated README.chromium Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorSession.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.h b/third_party/WebKit/Source/core/inspector/InspectorSession.h
index 6ffecf6c4379a251986c584fb5def570ba69ba59..31c512766e81dd82ce09445f1a7579d6bbdeddf2 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorSession.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.h
@@ -57,14 +57,24 @@ class CORE_EXPORT InspectorSession
private:
// protocol::FrontendChannel implementation.
- void sendProtocolResponse(int callId, const String& message) override;
- void sendProtocolNotification(const String& message) override;
+ void sendProtocolResponse(
+ int callId,
+ std::unique_ptr<protocol::Serializable> message) override;
+ void sendProtocolNotification(
+ std::unique_ptr<protocol::Serializable> message) override;
// v8_inspector::V8Inspector::Channel implementation.
+ void sendResponse(
+ int callId,
+ std::unique_ptr<v8_inspector::StringBuffer> message) override;
+ void sendNotification(
+ std::unique_ptr<v8_inspector::StringBuffer> message) override;
+ // TODO(kozyatinskiy): remove it.
void sendProtocolResponse(int callId,
- const v8_inspector::StringView& message) override;
- void sendProtocolNotification(
- const v8_inspector::StringView& message) override;
+ const v8_inspector::StringView& message) {}
+ void sendProtocolNotification(const v8_inspector::StringView& message) {}
+
+ void sendProtocolResponse(int callId, const String& message);
Client* m_client;
std::unique_ptr<v8_inspector::V8InspectorSession> m_v8Session;
@@ -74,7 +84,8 @@ class CORE_EXPORT InspectorSession
std::unique_ptr<protocol::UberDispatcher> m_inspectorBackendDispatcher;
std::unique_ptr<protocol::DictionaryValue> m_state;
HeapVector<Member<InspectorAgent>> m_agents;
- Vector<String> m_notificationQueue;
+ class Notification;
+ Vector<std::unique_ptr<Notification>> m_notificationQueue;
String m_lastSentState;
};

Powered by Google App Engine
This is Rietveld 408576698