Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 252233003: Reapply 266653 "[Mac] Allow fullscreen transitions while constrai..." (Closed)

Created:
6 years, 7 months ago by awong
Modified:
6 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews
Visibility:
Public.

Description

Reapply 266653 "[Mac] Allow fullscreen transitions while constrai..." PrintPreviewTest.TaskManagerNewPrintPreview was something else's fault. > Revert 266653 "[Mac] Allow fullscreen transitions while constrai..." > > Mac Tests (dbg) failing for PrintPreviewTest.TaskManagerNewPrintPreview > http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23012 > > > > [Mac] Allow fullscreen transitions while constrained windows are open. > > > > r166410 disabled the browser from entering fullscreen mode when any one > > tab has a constrained window open (e.g., Print dialog). However, this > > is inconsistent with the behavior on all other desktop platforms. This > > change removes the restriction. > > > > Landing on behalf of miu@chromium.org manually, as to make a branch cut. > > > > BUG=366567, 146451 > > TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos). Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open. > > R=avi@chromium.org, sky@chromium.org > > > > Review URL: https://codereview.chromium.org/253493005 > > TBR=avi@chromium.org > > Review URL: https://codereview.chromium.org/252693007 TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -39 lines) Patch
M trunk/src/chrome/browser/ui/browser_command_controller.cc View 1 chunk +1 line, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 2 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/ui/tabs/tab_strip_model_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/tabs/tab_strip_model_utils.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
6 years, 7 months ago (2014-04-29 16:51:00 UTC) #1
awong
6 years, 7 months ago (2014-04-29 16:51:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266899.

Powered by Google App Engine
This is Rietveld 408576698