Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 252233003: Reapply 266653 "[Mac] Allow fullscreen transitions while constrai..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm
===================================================================
--- trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm (revision 266898)
+++ trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm (working copy)
@@ -277,6 +277,20 @@
// Normally, we don't need to tell the toolbar whether or not to show the
// divider, but things break down during animation.
[toolbarController_ setDividerOpacity:[self toolbarDividerOpacity]];
+
+ // Update the position of the active constrained window sheet. We force this
+ // here because the |sheetParentView| may not have been resized (e.g., to
+ // prevent jank during a fullscreen mode transition), but constrained window
+ // sheets also compute their position based on the bookmark bar and toolbar.
+ content::WebContents* const activeWebContents =
+ browser_->tab_strip_model()->GetActiveWebContents();
+ NSView* const sheetParentView = activeWebContents ?
+ GetSheetParentViewForWebContents(activeWebContents) : nil;
+ if (sheetParentView) {
+ [[NSNotificationCenter defaultCenter]
+ postNotificationName:NSViewFrameDidChangeNotification
+ object:sheetParentView];
+ }
}
- (CGFloat)floatingBarHeight {

Powered by Google App Engine
This is Rietveld 408576698