Issue 252693007: Revert 266653 "[Mac] Allow fullscreen transitions while constrai..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252693007: Revert 266653 "[Mac] Allow fullscreen transitions while constrai..." (Closed)

Created:
6 years, 7 months ago by awong

Modified:
6 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 266653 "[Mac] Allow fullscreen transitions while constrai..." Mac Tests (dbg) failing for PrintPreviewTest.TaskManagerNewPrintPreview http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23012 > [Mac] Allow fullscreen transitions while constrained windows are open. > > r166410 disabled the browser from entering fullscreen mode when any one > tab has a constrained window open (e.g., Print dialog). However, this > is inconsistent with the behavior on all other desktop platforms. This > change removes the restriction. > > Landing on behalf of miu@chromium.org manually, as to make a branch cut. > > BUG=366567, 146451 > TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos). Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open. > R=avi@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/253493005 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266683

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -15 lines)			Patch
M	trunk/src/chrome/browser/ui/browser_command_controller.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/tabs/tab_strip_model_utils.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/tabs/tab_strip_model_utils.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r266683.