[Mac] Allow fullscreen transitions while constrained windows are open.

[Mac] Allow fullscreen transitions while constrained windows are open.

r166410 disabled the browser from entering fullscreen mode when any one
tab has a constrained window open (e.g., Print dialog).  However, this
is inconsistent with the behavior on all other desktop platforms.  This
change removes the restriction.

Landing on behalf of miu@chromium.org manually, as to make a branch cut.

BUG=366567, 146451
TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos).  Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open.
R=avi@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266653

[miu, 2014-04-25 22:01:25]

avi: PTAL.

[Avi (use Gerrit), 2014-04-26 00:01:28]

I don't have a problem with doing this as long as it works. You're going to
watch for crashes, yes?

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (left):

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:1266: int tab_index =
chrome::IndexOfFirstBlockedTab(browser_->tab_strip_model());
This was the only use of IndexOfFirstBlockedTab. Remove that functionality from
tab_strip_model_utils.

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:1263: #if !defined(OS_MACOSX)
This is wrong. This breaks kFullscreenAllowed for non-Macs. Remove this if
entirely.

[Avi (use Gerrit), 2014-04-26 00:22:41]

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:1263: #if !defined(OS_MACOSX)
On 2014/04/26 00:01:28, Avi wrote:
> This is wrong. This breaks kFullscreenAllowed for non-Macs. Remove this if
> entirely.

Sorry, I misread this; I'm wrong here.

Though we still want to drop this #if so that the Mac also obeys the
kFullscreenAllowed pref.

[miu, 2014-04-26 01:07:03]

sky: Need OWNERS stamp for deleting dead code from
chrome/browser/ui/tabs/tab_strip_model_utils.*.

avi: Addressed your comments:

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (left):

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:1266: int tab_index =
chrome::IndexOfFirstBlockedTab(browser_->tab_strip_model());
On 2014/04/26 00:01:28, Avi wrote:
> This was the only use of IndexOfFirstBlockedTab. Remove that functionality
from
> tab_strip_model_utils.

Done.

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:1263: #if !defined(OS_MACOSX)
On 2014/04/26 00:22:42, Avi wrote:
> Though we still want to drop this #if so that the Mac also obeys the
> kFullscreenAllowed pref.

Yes, this looked wrong to me too.  However, when I remove it, the Mac fullscreen
controls become completely ineffective.

Looking at source control history, r219482 is responsible for it.  Throughout
that change, bartfab@ put the #if !defined(MAC_OSX) in a bunch of other places
too.  There must be a reason the fullscreen prefs don't apply for Mac.

Whether this should be fixed or not, I feel it's best to keep the scope of this
change as small as possible (in case we merge into M35), so I've left this
alone.

[Avi (use Gerrit), 2014-04-26 02:49:28]

OK, then LGTM. Cross your fingers.

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/253493005/diff/50001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:1263: #if !defined(OS_MACOSX)
Weird.

OK, then.

[sky, 2014-04-28 13:45:42]

LGTM

[miu, 2014-04-28 15:37:38]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:38:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/253493005/70001

[commit-bot: I haz the power, 2014-04-28 16:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:24:04]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[miu, 2014-04-28 16:28:20]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:28:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/253493005/70001

[commit-bot: I haz the power, 2014-04-28 17:03:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:03:11]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[Avi (use Gerrit), 2014-04-28 18:58:59]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:59:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/253493005/70001

[Avi (use Gerrit), 2014-04-28 20:54:42]

Committed patchset #2 manually as r266653 (presubmit successful).