Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2521833002: [LayoutNG] Add out-of-flow descendants and offsets to NGPhysicalFragment (Closed)

Created:
4 years, 1 month ago by atotic
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add out-of-flow descendants and offsets to NGPhysicalFragment More prep work for abspos: Adds a list of out-of-flow descendants and their offsets to NGPhysicalFragment. NGBlockLayoutAlgorithm needs to pass boxes it was unable to place (out-of-flow) to its parent. This will be done by storing unplaced boxes on the generated fragment. BUG=635619 Committed: https://crrev.com/69dbc5fcb1586d6aa49f58863d6b26d24d336b15 Cr-Commit-Position: refs/heads/master@{#433945}

Patch Set 1 #

Patch Set 2 : Fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 4 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 chunk +19 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
atotic
4 years, 1 month ago (2016-11-22 01:00:13 UTC) #3
eae
OK, LGTM
4 years, 1 month ago (2016-11-22 01:10:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521833002/1
4 years, 1 month ago (2016-11-22 03:55:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/301281)
4 years, 1 month ago (2016-11-22 05:28:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521833002/20001
4 years, 1 month ago (2016-11-22 18:04:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 19:47:24 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 19:49:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69dbc5fcb1586d6aa49f58863d6b26d24d336b15
Cr-Commit-Position: refs/heads/master@{#433945}

Powered by Google App Engine
This is Rietveld 408576698