Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2521833002: [LayoutNG] Add out-of-flow descendants and offsets to NGPhysicalFragment (Closed)
Patch Set: Fix windows build Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index c0ea5f09dc28c455175b814bdab78736ddcbc448..2e8f772d9d0d9036a42e7a940d76158401258b1a 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -15,6 +15,8 @@ class CORE_EXPORT NGFragmentBuilder final
public:
NGFragmentBuilder(NGPhysicalFragmentBase::NGFragmentType);
+ using WeakBoxList = HeapLinkedHashSet<WeakMember<NGBox>>;
+
NGFragmentBuilder& SetWritingMode(NGWritingMode);
NGFragmentBuilder& SetDirection(TextDirection);
@@ -26,6 +28,9 @@ class CORE_EXPORT NGFragmentBuilder final
NGFragmentBuilder& AddChild(NGFragmentBase*, NGLogicalOffset);
+ NGFragmentBuilder& SetOutOfFlowDescendants(WeakBoxList&,
+ Vector<NGLogicalOffset>&);
+
// Sets MarginStrut for the resultant fragment.
NGFragmentBuilder& SetMarginStrutBlockStart(const NGMarginStrut& from);
NGFragmentBuilder& SetMarginStrutBlockEnd(const NGMarginStrut& from);
@@ -36,7 +41,7 @@ class CORE_EXPORT NGFragmentBuilder final
// Creates the fragment. Can only be called once.
NGPhysicalFragment* ToFragment();
- DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(children_); }
+ DECLARE_VIRTUAL_TRACE();
private:
NGPhysicalFragmentBase::NGFragmentType type_;
@@ -50,6 +55,8 @@ class CORE_EXPORT NGFragmentBuilder final
HeapVector<Member<NGPhysicalFragmentBase>> children_;
Vector<NGLogicalOffset> offsets_;
+ WeakBoxList out_of_flow_descendants_;
+ Vector<NGLogicalOffset> out_of_flow_offsets_;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698