Properly define v8_enable_inspector and its override in GN.

Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects, and reduces the
need to include //build_overrides/v8.gni in many files.

Committed: https://crrev.com/ae0e92219b131551a6876034c890bfe5f80c6d1f
Cr-Commit-Position: refs/heads/master@{#41156}

[Lei Zhang, 2016-11-19 18:47:06]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 18:47:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 19:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 19:31:52]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-19 20:26:29]

thestig@chromium.org changed reviewers:
+ dpranke@chromium.org, jochen@chromium.org

[Dirk Pranke, 2016-11-19 20:36:16]

Can you expand the CL description? Why is this the "proper" implementation?

[Lei Zhang, 2016-11-20 06:39:34]

Description was changed from

==========
Properly define v8_enable_inspector and its override in GN.
==========

to

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects.
==========

[Lei Zhang, 2016-11-20 06:40:11]

Description was changed from

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects.
==========

to

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects, and reduces the
need to include //build_overrides/v8.gni in many files.
==========

[Lei Zhang, 2016-11-20 06:40:17]

On 2016/11/19 20:36:16, Dirk Pranke wrote:
> Can you expand the CL description? Why is this the "proper" implementation?

Done.

[Dirk Pranke, 2016-11-20 19:44:07]

lgtm, thanks.

[jochen (gone - plz use gerrit), 2016-11-21 11:06:41]

jochen@chromium.org changed reviewers:
+ machenbach@chromium.org

[jochen (gone - plz use gerrit), 2016-11-21 11:06:41]

deferring to machenbach

[Michael Achenbach, 2016-11-21 18:11:21]

lgtm, thanks for improving the code.

cc kozyatinskiy fyi

[Lei Zhang, 2016-11-21 19:04:05]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-11-21 19:28:51]

thanks!

[commit-bot: I haz the power, 2016-11-21 19:29:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479755045189770, "parent_rev":
"b4afe9bbbcd26d3fa354ca092c58c688e09deeeb", "commit_rev":
"c4fc1b39d6e206bfd2ba168f985e76f330e987ae"}

[commit-bot: I haz the power, 2016-11-21 19:29:09]

Description was changed from

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects, and reduces the
need to include //build_overrides/v8.gni in many files.
==========

to

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects, and reduces the
need to include //build_overrides/v8.gni in many files.
==========

[commit-bot: I haz the power, 2016-11-21 19:29:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 19:29:51]

Description was changed from

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects, and reduces the
need to include //build_overrides/v8.gni in many files.
==========

to

==========
Properly define v8_enable_inspector and its override in GN.

Instead of directly using v8_enable_inspector_override from
build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
variable based on v8_enable_inspector_override and use that everywhere.
This is the more common pattern seen in over projects, and reduces the
need to include //build_overrides/v8.gni in many files.

Committed: https://crrev.com/ae0e92219b131551a6876034c890bfe5f80c6d1f
Cr-Commit-Position: refs/heads/master@{#41156}
==========

[commit-bot: I haz the power, 2016-11-21 19:29:52]

Patchset 1 (id:??) landed as
https://crrev.com/ae0e92219b131551a6876034c890bfe5f80c6d1f
Cr-Commit-Position: refs/heads/master@{#41156}