Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: BUILD.gn

Issue 2520683002: Properly define v8_enable_inspector and its override in GN. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 9983b3a54e3a29249c8dea272c61cf21dcba70c4..14303d663567837a3e48a63ea9c66aa663ee37d3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -14,8 +14,6 @@ if (is_android) {
import("gni/v8.gni")
import("gni/isolate.gni")
-import("//build_overrides/v8.gni")
-
import("snapshot_toolchain.gni")
declare_args() {
@@ -155,7 +153,7 @@ config("external_config") {
defines = [ "USING_V8_SHARED" ]
}
include_dirs = [ "include" ]
- if (v8_enable_inspector_override) {
+ if (v8_enable_inspector) {
include_dirs += [ "$target_gen_dir/include" ]
}
}
@@ -742,7 +740,7 @@ action("v8_dump_build_config") {
"is_tsan=$is_tsan",
"target_cpu=\"$target_cpu\"",
"v8_enable_i18n_support=$v8_enable_i18n_support",
- "v8_enable_inspector=$v8_enable_inspector_override",
+ "v8_enable_inspector=$v8_enable_inspector",
"v8_target_cpu=\"$v8_target_cpu\"",
"v8_use_snapshot=$v8_use_snapshot",
]
@@ -2199,7 +2197,7 @@ v8_source_set("v8_base") {
deps += [ ":postmortem-metadata" ]
}
- if (v8_enable_inspector_override) {
+ if (v8_enable_inspector) {
deps += [ "src/inspector:inspector" ]
}
}
@@ -2574,7 +2572,7 @@ v8_executable("d8") {
}
defines = []
- if (v8_enable_inspector_override) {
+ if (v8_enable_inspector) {
defines += [ "V8_INSPECTOR_ENABLED" ]
}
}
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698