Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: BUILD.gn

Issue 2520683002: Properly define v8_enable_inspector and its override in GN. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/dcheck_always_on.gni") 7 import("//build/config/dcheck_always_on.gni")
8 import("//build/config/mips.gni") 8 import("//build/config/mips.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
11 if (is_android) { 11 if (is_android) {
12 import("//build/config/android/rules.gni") 12 import("//build/config/android/rules.gni")
13 } 13 }
14 14
15 import("gni/v8.gni") 15 import("gni/v8.gni")
16 import("gni/isolate.gni") 16 import("gni/isolate.gni")
17 import("//build_overrides/v8.gni")
18
19 import("snapshot_toolchain.gni") 17 import("snapshot_toolchain.gni")
20 18
21 declare_args() { 19 declare_args() {
22 # Print to stdout on Android. 20 # Print to stdout on Android.
23 v8_android_log_stdout = false 21 v8_android_log_stdout = false
24 22
25 # Sets -DVERIFY_HEAP. 23 # Sets -DVERIFY_HEAP.
26 v8_enable_verify_heap = false 24 v8_enable_verify_heap = false
27 25
28 # Enable compiler warnings when using V8_DEPRECATED apis. 26 # Enable compiler warnings when using V8_DEPRECATED apis.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 include_dirs = [ "include" ] 146 include_dirs = [ "include" ]
149 } 147 }
150 148
151 # This config should only be applied to code using V8 and not any V8 code 149 # This config should only be applied to code using V8 and not any V8 code
152 # itself. 150 # itself.
153 config("external_config") { 151 config("external_config") {
154 if (is_component_build) { 152 if (is_component_build) {
155 defines = [ "USING_V8_SHARED" ] 153 defines = [ "USING_V8_SHARED" ]
156 } 154 }
157 include_dirs = [ "include" ] 155 include_dirs = [ "include" ]
158 if (v8_enable_inspector_override) { 156 if (v8_enable_inspector) {
159 include_dirs += [ "$target_gen_dir/include" ] 157 include_dirs += [ "$target_gen_dir/include" ]
160 } 158 }
161 } 159 }
162 160
163 # This config should only be applied to code that needs to be explicitly 161 # This config should only be applied to code that needs to be explicitly
164 # aware of whether we are using startup data or not. 162 # aware of whether we are using startup data or not.
165 config("external_startup_data") { 163 config("external_startup_data") {
166 if (v8_use_external_startup_data) { 164 if (v8_use_external_startup_data) {
167 defines = [ "V8_USE_EXTERNAL_STARTUP_DATA" ] 165 defines = [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
168 } 166 }
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 rebase_path("$root_out_dir/v8_build_config.json", root_build_dir), 733 rebase_path("$root_out_dir/v8_build_config.json", root_build_dir),
736 "dcheck_always_on=$dcheck_always_on", 734 "dcheck_always_on=$dcheck_always_on",
737 "is_asan=$is_asan", 735 "is_asan=$is_asan",
738 "is_cfi=$is_cfi", 736 "is_cfi=$is_cfi",
739 "is_component_build=$is_component_build", 737 "is_component_build=$is_component_build",
740 "is_debug=$is_debug", 738 "is_debug=$is_debug",
741 "is_msan=$is_msan", 739 "is_msan=$is_msan",
742 "is_tsan=$is_tsan", 740 "is_tsan=$is_tsan",
743 "target_cpu=\"$target_cpu\"", 741 "target_cpu=\"$target_cpu\"",
744 "v8_enable_i18n_support=$v8_enable_i18n_support", 742 "v8_enable_i18n_support=$v8_enable_i18n_support",
745 "v8_enable_inspector=$v8_enable_inspector_override", 743 "v8_enable_inspector=$v8_enable_inspector",
746 "v8_target_cpu=\"$v8_target_cpu\"", 744 "v8_target_cpu=\"$v8_target_cpu\"",
747 "v8_use_snapshot=$v8_use_snapshot", 745 "v8_use_snapshot=$v8_use_snapshot",
748 ] 746 ]
749 } 747 }
750 748
751 ############################################################################### 749 ###############################################################################
752 # Source Sets (aka static libraries) 750 # Source Sets (aka static libraries)
753 # 751 #
754 752
755 source_set("v8_maybe_snapshot") { 753 source_set("v8_maybe_snapshot") {
(...skipping 1436 matching lines...) Expand 10 before | Expand all | Expand 10 after
2192 "src/i18n.cc", 2190 "src/i18n.cc",
2193 "src/i18n.h", 2191 "src/i18n.h",
2194 ] 2192 ]
2195 } 2193 }
2196 2194
2197 if (v8_postmortem_support) { 2195 if (v8_postmortem_support) {
2198 sources += [ "$target_gen_dir/debug-support.cc" ] 2196 sources += [ "$target_gen_dir/debug-support.cc" ]
2199 deps += [ ":postmortem-metadata" ] 2197 deps += [ ":postmortem-metadata" ]
2200 } 2198 }
2201 2199
2202 if (v8_enable_inspector_override) { 2200 if (v8_enable_inspector) {
2203 deps += [ "src/inspector:inspector" ] 2201 deps += [ "src/inspector:inspector" ]
2204 } 2202 }
2205 } 2203 }
2206 2204
2207 v8_component("v8_libbase") { 2205 v8_component("v8_libbase") {
2208 sources = [ 2206 sources = [
2209 "src/base/adapters.h", 2207 "src/base/adapters.h",
2210 "src/base/atomic-utils.h", 2208 "src/base/atomic-utils.h",
2211 "src/base/atomicops.h", 2209 "src/base/atomicops.h",
2212 "src/base/atomicops_internals_atomicword_compat.h", 2210 "src/base/atomicops_internals_atomicword_compat.h",
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
2567 sources += [ "src/d8-posix.cc" ] 2565 sources += [ "src/d8-posix.cc" ]
2568 } else if (is_win) { 2566 } else if (is_win) {
2569 sources += [ "src/d8-windows.cc" ] 2567 sources += [ "src/d8-windows.cc" ]
2570 } 2568 }
2571 2569
2572 if (v8_enable_i18n_support) { 2570 if (v8_enable_i18n_support) {
2573 deps += [ "//third_party/icu" ] 2571 deps += [ "//third_party/icu" ]
2574 } 2572 }
2575 2573
2576 defines = [] 2574 defines = []
2577 if (v8_enable_inspector_override) { 2575 if (v8_enable_inspector) {
2578 defines += [ "V8_INSPECTOR_ENABLED" ] 2576 defines += [ "V8_INSPECTOR_ENABLED" ]
2579 } 2577 }
2580 } 2578 }
2581 2579
2582 v8_isolate_run("d8") { 2580 v8_isolate_run("d8") {
2583 deps = [ 2581 deps = [
2584 ":d8", 2582 ":d8",
2585 ] 2583 ]
2586 2584
2587 isolate = "//src/d8.isolate" 2585 isolate = "//src/d8.isolate"
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
3001 ] 2999 ]
3002 3000
3003 configs = [ 3001 configs = [
3004 ":external_config", 3002 ":external_config",
3005 ":internal_config_base", 3003 ":internal_config_base",
3006 ] 3004 ]
3007 } 3005 }
3008 3006
3009 v8_fuzzer("wasm_data_section_fuzzer") { 3007 v8_fuzzer("wasm_data_section_fuzzer") {
3010 } 3008 }
OLDNEW
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698