Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: gni/v8.gni

Issue 2520683002: Properly define v8_enable_inspector and its override in GN. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gni/isolate.gni ('k') | test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index 3759572b935157e65237443c84ef456c508c2010..d2b4da825e630887619d6e84757b3f51b1fb60dd 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -4,6 +4,7 @@
import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/v8_target_cpu.gni")
+import("//build_overrides/v8.gni")
declare_args() {
# Indicate if valgrind was fetched as a custom deps to make it available on
@@ -30,6 +31,9 @@ declare_args() {
# Enable ECMAScript Internationalization API. Enabling this feature will
# add a dependency on the ICU library.
v8_enable_i18n_support = true
+
+ # Enable inspector. See include/v8-inspector.h.
+ v8_enable_inspector = v8_enable_inspector_override
}
if (v8_use_external_startup_data == "") {
« no previous file with comments | « gni/isolate.gni ('k') | test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698